Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pycyphal & python3Packages.pyuavcan: init pycyphal at 1.15.2 & deprecate pyuavcan #249535

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

kip93
Copy link
Contributor

@kip93 kip93 commented Aug 16, 2023

Description of changes

Adds the pycyphal python package, and deprecates pyuavcan (they're the same package, it's just been renamed).

(Won't cross compile until dependencies bellow are merged)

Depends on #249520, #249524, #249532, & #249157

NOTE: The "error" that ofborg shows seems to only be about the deprecation warning.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (cross compiled from x86_64-linux)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kip93 kip93 mentioned this pull request Aug 16, 2023
12 tasks
@kip93 kip93 changed the title python3Packages.pycyphal: init at 1.15.2 python3Packages.pycyphal & python3Packages.pyuavcan: init pycyphal at 1.15.2 & deprecate pyuavcan Aug 21, 2023
@kip93 kip93 force-pushed the feature/add-pycyphal branch 4 times, most recently from 26cef89 to ac6bac0 Compare August 29, 2023 14:55
@globin globin merged commit 0275858 into NixOS:master Nov 14, 2023
9 of 10 checks passed
@bobby285271
Copy link
Member

bobby285271 commented Nov 14, 2023

I reverted 7b13a35 in #267423 since CI is red here

(I remember there is RFC 127 talking about something similar, but I did not really follow the progress...)

@kip93
Copy link
Contributor Author

kip93 commented Nov 14, 2023

I thought this was not going to make 23.11, so I haven't tested it as of late, but last time the error was because of the deprecation warning. Maybe it needs a bit more love to make the deprecation warning work? Or we could keep both packages for now and then deprecate pyuavcan on 24.05.

@kip93
Copy link
Contributor Author

kip93 commented Nov 14, 2023

And if you reverted this, you'd need to also revert #249548 since it depends on this

@bobby285271
Copy link
Member

#267423 only drops the lib.warn, how would #249548 depend on it?

@kip93
Copy link
Contributor Author

kip93 commented Nov 14, 2023

Oh I missread the title I thought you reverted this entire PR. Then yakut is fine

@kip93 kip93 deleted the feature/add-pycyphal branch February 9, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants