-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.sphinxHook: Fix cross compilation #249157
Conversation
4f4f118
to
2da3714
Compare
Changed target branch to staging and rebased due to number of rebuilds. |
100ae35
to
c7454bd
Compare
hooks/default change no longer necessary since #247245
|
Just rebased with staging to be sure, but it still fails to cross compile wrap without this, with the same error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I forgot that my pr only fixed splicing python3Packages.callPackage { python }:
while the hook splicing within the set (used by callPackage) is still broken and will eventually be fixed by #228139
the rebuilds are a bit weird so i'll check why that is happening
c7454bd
to
2177094
Compare
Failed due to using host sphinx instead of build one.
2177094
to
a391639
Compare
I checked and there's really no rebuilds, rebuild count is likely just because of a rebase gone wrong |
Fixes some side effects of NixOS#249157 (see NixOS#255810)
Fixes build of wrapt. Also removed the now irrelevant workaround on beautifulsoup4.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)