multiple-outputs.sh: Install static libraries into $static->$dev->$out
#229725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"First official release on github, rather than sourceforge (as in the past)", according to the github tag message in https://github.com/NetworkBlockDevice/nbd/releases/tag/nbd-3.25 Note that the commit at hand also fixes the build after it broke due to the update to GLib 2.75.3 ("Log limit exceeded") in NixOS@8e5ee71
python310Packages.aiomisc: 17.1.4 -> 17.2.2
nbd: 3.24 -> 3.25, fix build broken by GLib update
There's no libgcc.so in a static-only build.
…theme-square numix-icon-theme-square: 23.04.20 -> 23.04.28
During `preFixup`, static libraries (`lib/*.a`) are now installed to the `$static` output if it exists, or the `$dev` output if that exists, or just to `$out` as usual. This will make it easier to prevent static libs making it into system closures.
|
This should target staging. |
Hi! What does that mean? |
The staging branch, I mean. This PR would surely cause mass rebuilds, it can't go directly into master. |
|
Closed in favor of #229758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
During
preFixup, static libraries (lib/*.a) are now installed to the$staticoutput if it exists, or the$devoutput if that exists, or just to$outas usual.This will make it easier to prevent static libs making it into system closures.
Related issues:
#164141
#224533
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)