nbd: 3.24 -> 3.25, fix build broken by GLib update #229123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"First official release on github, rather than sourceforge (as in the past)", according to the github tag message in https://github.com/NetworkBlockDevice/nbd/releases/tag/nbd-3.25 Note that the commit at hand also fixes the build after it broke due to the update to GLib 2.75.3 ("Log limit exceeded") in NixOS@8e5ee71
Yarny0
changed the title
|
nbd released a new version yesterday. According to a statement in the git tag on github, they are now moving to github with their releases. So I replaced the my previous branch that fixed the issue with two patches with a branch that simply updates to the new version. Also rebased onto current |
|
Seems to work for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The update of GLib coming with #218143 broke the
nbdbuild (the server part is broken and lets the test suite fail, https://hydra.nixos.org/build/215806781).We have to apply two patches from upstream tonbd-server.cto make it work again.The pull request at hand simply updates to the newest release which fixes those issues. It also changes the source archive download link to a github URL as it seems nbd is moving from sourceforge to github ("First official release on github, rather than sourceforge (as in the past)").
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Besides the NixOS VM test, I also tested with a netboot scenario where the client uses server disk space via nbd for swapping (tested for client and server).
Result of
nixpkgs-reviewrun on x86_64-linux 11 package built: