Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uhd: fix cross #226558

Merged
1 commit merged into from Apr 17, 2023
Merged

uhd: fix cross #226558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/applications/radio/uhd/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ stdenv.mkDerivation rec {
nativeBuildInputs = [
cmake
pkg-config
python3
]
# If both enableLibuhd_Python_api and enableUtils are off, we don't need
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It'd be better to add pythonEnv unconditionally to nativeBuildInputs - it'll evaluate to a python environment without any python packages in it.

I remember I was thinking about it when I wrote the comment here, and I haven't checked cross compilation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd also be nice to test cross compilation with enablePythonApi = true;, and comment whether it works or not.

# pythonEnv in buildInputs as it's a 'build' dependency and not a runtime
Expand Down