uhd: fix cross #226558
uhd: fix cross #226558
Conversation
This commit adds `python3` to `nativeBuildInputs` in order to fix cross compilation of `uhd`.
ofborg
bot
added
the
6.topic: cross-compilation
ghost
merged commit 
| @@ -93,6 +93,7 @@ stdenv.mkDerivation rec { | |||
| nativeBuildInputs = [ | |||
| cmake | |||
| pkg-config | |||
| python3 | |||
| ] | |||
| # If both enableLibuhd_Python_api and enableUtils are off, we don't need | |||
There was a problem hiding this comment.
Thanks for the PR. It'd be better to add pythonEnv unconditionally to nativeBuildInputs - it'll evaluate to a python environment without any python packages in it.
I remember I was thinking about it when I wrote the comment here, and I haven't checked cross compilation.
There was a problem hiding this comment.
It'd also be nice to test cross compilation with enablePythonApi = true;, and comment whether it works or not.
|
Also, when there are so many maintainers (4 in this case), it'd be nice to wait more then 4 hours for more approvals, and give more time for them to respond. |
Sorry about that. I have a huge pile of these one-liners from my "cross compile the whole laptop" push. I definitely wait longer when the PR is something nontrivial. |
It's OK. Feel free to ping me for such cross compile PRs, it's a topic of interest to me as well. I'll also appreciate your review for #226676, and would be interested to learn about your goal with cross compiling |
Description of changes
This commit adds
python3tonativeBuildInputsin order to fix cross compilation ofuhd.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)