-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmPackages_git.openmp: apply #197674 (fix cross compile) #222903
llvmPackages_git.openmp: apply #197674 (fix cross compile) #222903
Conversation
4b928c1
to
3ff445d
Compare
3ff445d
to
bba47c0
Compare
this was backported to `llvmPackages_15` in 81ef82a
bba47c0
to
61b348f
Compare
I'm not sure what to test here, I will try: @ofborg build pkgsCross.aarch64-multiplatform.llvmPackages_git.openmp |
Hmm looks like the FileCheck JSON error from #222220 is back 🙁. I'll see if I can reproduce locally. I finally managed to reproduce this locally. # using `cntr` and `breakpointHook` (set `postCheck` to `exit 4` or something)
cd build/llvm-src-unstable-2022-26-07/llvm/build
# Edit: /var/lib/cntr/build/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/lit.site.cfg
# Edit: /var/lib/cntr/build/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/Unit/lit.site.cfg
# Edit: /var/lib/cntr/build/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/UnitIsl/lit.site.cfg
# Edit: /var/lib/cntr/build/llvm-src-unstable-2022-26-07/llvm/build/utils/lit/lit.site.cfg
# make paths point to `/var/lib/cntr/build`...
python3.10 ./bin/llvm-lit -svj88 --no-progress-bar \
--param polly_site_config=tools/polly/test/lit.site.cfg \
--param polly_unit_site_config=tools/polly/test/Unit/lit.site.cfg \
--param polly_site_config=tools/polly/test/Unit/lit.site.cfg \
--param polly_site_config=tools/polly/test/UnitIsl/lit.site.cfg \
tools/polly/test \
tools/polly/test/Unit \
tools/polly/test/UnitIsl \
utils/lit \
test \
--filter ScopPassManager
# Running ^ repeatedly is a fast way to reproduce Sometimes there will be extra lines in gtest produced JSON files; for example, {
"tests": 1,
"failures": 0,
"disabled": 0,
"errors": 0,
"timestamp": "2023-04-10T18:57:23Z",
"time": "0s",
"name": "AllTests",
"testsuites": [
{
"name": "ScopPassRegistry",
"tests": 1,
"failures": 0,
"disabled": 0,
"errors": 0,
"timestamp": "2023-04-10T18:57:23Z",
"time": "0s",
"testsuite": [
{
"name": "PrintScopInfo",
"status": "RUN",
"result": "COMPLETED",
"timestamp": "2023-04-10T18:57:23Z",
"time": "0s",
"classname": "ScopPassRegistry"
}
]
}
]
}
]
} (note the two extra lines) the number of extra lines, contents, etc, are not consistent; sometimes I get: }
}
]
} |
This was applied to
llvmPackages_15
in 81ef82a.I ended up needing this in #213202 to apply the
libclc
changes there tollvmPackages_git
(likeopenmp
,libclc
wantstargetLlvm
).Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)