openmp: fix cross compile #197674
Merged
openmp: fix cross compile #197674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squalus
added
the
6.topic: cross-compilation
delroth
reviewed
Oct 31, 2022
| @@ -15,7 +16,9 @@ stdenv.mkDerivation rec { | |||
| src = fetch pname "0i4bn84lkpm5w3qkpvwm5z6jdj8fynp7d3bcasa1xyq4is6757yi"; | |||
|
|
|||
| nativeBuildInputs = [ cmake perl ]; | |||
| buildInputs = [ llvm ]; | |||
| buildInputs = [ | |||
| (if stdenv.buildPlatform == stdenv.hostPlatform then llvm else targetLlvm) | |||
There was a problem hiding this comment.
(Commenting only on this one particular instance, but obviously applies to all.)
When buildPlatform == hostPlatform is there a meaningful difference between llvm and targetLlvm? In other words, could we always use targetLlvm here?
If this is done only to avoid rebuilds, I'd personally prefer rebuilds to long term code complexity / "technical debt".
There was a problem hiding this comment.
Here's why: if I simply use targetLlvm, then pkgsCross.aarch64-multiplatform.buildPackages.llvmPackages_14.openmp will result in a failed build. The "build" version of the llvm libraries is included instead of the expected "host" version. I admit I'm not sure why this is the case. There may be a better way to model this.
92 tasks
Artturin
approved these changes
Nov 21, 2022
|
@ofborg build pkgsCross.aarch64-multiplatform.llvmPackages_14.openmp |
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Jan 8, 2023
See NixOS#194634 for details. PRs: - NixOS#191372 - NixOS#190936 - NixOS#82131 - NixOS#199844 - NixOS#197674 - NixOS#184408 - NixOS#193004
ElvishJerricco
pushed a commit
to ElvishJerricco/nixpkgs
that referenced
this pull request
Jan 8, 2023
See NixOS#194634 for details. PRs: - NixOS#191372 - NixOS#190936 - NixOS#82131 - NixOS#199844 - NixOS#197674 - NixOS#184408 - NixOS#193004
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Jan 10, 2023
See NixOS#194634 for details. PRs: - NixOS#191372 - NixOS#190936 - NixOS#82131 - NixOS#199844 - NixOS#197674 - NixOS#184408 - NixOS#193004
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Jan 27, 2023
See NixOS#194634 for details. PRs: - NixOS#191372 - NixOS#190936 - NixOS#82131 - NixOS#199844 - NixOS#197674 - NixOS#184408 - NixOS#193004
xanderio
pushed a commit
to xanderio/nixpkgs
that referenced
this pull request
Feb 13, 2023
See NixOS#194634 for details. PRs: - NixOS#191372 - NixOS#190936 - NixOS#82131 - NixOS#199844 - NixOS#197674 - NixOS#184408 - NixOS#193004
48 tasks
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Apr 3, 2023
this was backported to `llvmPackages_15` in 81ef82a
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Apr 5, 2023
this was backported to `llvmPackages_15` in 81ef82a
RaitoBezarius
pushed a commit
that referenced
this pull request
Apr 14, 2023
this was backported to `llvmPackages_15` in 81ef82a
RaitoBezarius
pushed a commit
to rrbutani/nixpkgs
that referenced
this pull request
Apr 16, 2023
this was backported to `llvmPackages_15` in 81ef82a
RaitoBezarius
added a commit
that referenced
this pull request
Apr 19, 2023
llvmPackages_git.openmp: apply #197674 (fix cross compile)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes cross compile for openmp.
Doesn't cause any rebuilds.
Tested cross builds from x86_64-linux -> aarch64-linux on llvmPackages 10 through 14. Tested all evaluations. Tested compilation of a few dependent packages.
The following attrs are now expected to build:
The following attrs are expected to produce the same output as the normal native build:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes