udev: set to libudev-zero on static linux #210276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd does not support being built statically[1], which means that, prior to this patch, nothing that depends on udev can be built statically. libudev-zero is a daemonless implementation of libudev, that supports being built statically. So, by setting udev to be libudev-zero when systemd is unavailable, we can get static builds of packages like linuxPackages.usbip. [1]: systemd/systemd#20600 (comment)
5 tasks
ghost
approved these changes
Jan 12, 2023
| udev = systemd; # TODO: change to systemdMinimal | ||
| udev = | ||
| if (with stdenv.hostPlatform; isLinux && isStatic) then libudev-zero | ||
| else systemd; # TODO: change to systemdMinimal |
There was a problem hiding this comment.
lets see how that goes #212975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
systemd does not support being built statically1, which means that, prior to this patch, nothing that depends on udev can be built statically. libudev-zero is a daemonless implementation of libudev, that supports being built statically. So, by setting udev to be libudev-zero when systemd is unavailable, we can get static builds of packages like linuxPackages.usbip.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes