-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt-6/modules/qtbase: add systemdSupport parameter #192057
Conversation
Should systemd also be removed from buildInputs when systemdSupport is disabled? |
Yes thank you; I didn't notice that because I have to
due to there being a few packages (like emacs) that still don't respect |
Notice that udev is also systemd under the hood, better check if that matters. |
Ah yes, I keep forgetting about that. Such a footgun. Why can't we just call |
Fortunately it does not matter in this case. |
Ping |
Resolved merge conflict. |
because udev was merged in to systemd in 2012 |
There are at least two non- We really ought to have a top-level We refer to:
|
Calling it udev is fine. Selecting different implementations conditionally is being implemented: #210276 |
Hooray! |
Description of changes
Defaults to
stdenv.isLinux
. Tested by buildingladybird
with.override { systemdSupport = false; }
.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
:ladybird
)