Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch-install-scripts: 26 -> 27 #197594

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

SamLukeYes
Copy link
Member

@SamLukeYes SamLukeYes commented Oct 24, 2022

Description of changes

This update introduces -K option to pacstrap, which initializes an empty pacman keyring in the target root instead of copying the existing keyring from the host. This option won't work without #192896 or manually adding pacman package to PATH.

However, even with the above change applied, I found pacstrap -K not automatically populating archlinux-keyring after installing it to the new root, and I had to manually run pacman-key --populate before installing packages in the chroot. 😕

UPDATE: Using pacstrap without -K doesn't trigger pacman-key --populate either, but it'll copy the gpgdir from the host to the target, so I didn't notice this problem before. Maybe I'll open an issue to track it later.

My bad! That was because I added etc/pacman.d/mirrorlist to NoExtract in my pacman.conf.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1323

@SuperSandro2000 SuperSandro2000 merged commit 60b1608 into NixOS:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants