Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacman: add missing PATHs #192896

Merged
merged 2 commits into from
Oct 29, 2022
Merged

pacman: add missing PATHs #192896

merged 2 commits into from
Oct 29, 2022

Conversation

SamLukeYes
Copy link
Member

@SamLukeYes SamLukeYes commented Sep 25, 2022

Description of changes

Adding compression tools to buildInputs doesn't seem to affect repo-add script. Let's add them to the PATH of compress.sh instead. Now repo-add should work in a pure shell.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SamLukeYes SamLukeYes changed the title pacman: set PATH in compress.sh pacman: add missing PATHs Oct 24, 2022
@SamLukeYes
Copy link
Member Author

Also added $out/bin to the PATH of pacman-key to make it work properly when used as a runtime dependency.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1323

@SuperSandro2000 SuperSandro2000 merged commit 19f597b into NixOS:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants