tor-browser-bundle-bin: fallback to web.archive.org links #191492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
reviewed
Sep 17, 2022
| @@ -95,6 +95,7 @@ let | |||
| x86_64-linux = fetchurl { | |||
| urls = [ | |||
| "https://dist.torproject.org/torbrowser/${version}/tor-browser-linux64-${version}_${lang}.tar.xz" | |||
| "https://web.archive.org/web/20220916130350/https://tor.eff.org/dist/torbreawser/${version}/tor-browser-linux64-${version}_${lang}.tar.xz" | |||
There was a problem hiding this comment.
Not sure if that's a good idea: when updating the version now, the web.archive.org link will be brokne because of the "timestamp", correct?
Not sure what would be a better solution here, though.
There was a problem hiding this comment.
We can request the date * but then it still needs to be uploaded to web.archive.org before deletion.
There was a problem hiding this comment.
One could write a checklist on what to do when updating this package which includes that.
There was a problem hiding this comment.
Would a comment on the timestamp be good enough?
ghost
mentioned this pull request
|
https://archive.torproject.org achieves the same thing and is soon to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #190045
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes