Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build tor-browser-bundle-bin: 404 #190045

Closed
ghost opened this issue Sep 6, 2022 · 4 comments · Fixed by #192220
Closed

Cannot build tor-browser-bundle-bin: 404 #190045

ghost opened this issue Sep 6, 2022 · 4 comments · Fixed by #192220

Comments

@ghost
Copy link

ghost commented Sep 6, 2022

Steps To Reproduce

Steps to reproduce the behavior:

nix-shell -p tor-browser-bundle-bin

Build log

these 2 derivations will be built:
  /nix/store/s0gv1j6fqzjzgr9kqvndhcgsmwivjzhi-tor-browser-linux64-11.5.1_en-US.tar.xz.drv
  /nix/store/0faf1b6dnqisg7666hhrrn2hs16d9b93-tor-browser-bundle-bin-11.5.1.drv
building '/nix/store/s0gv1j6fqzjzgr9kqvndhcgsmwivjzhi-tor-browser-linux64-11.5.1_en-US.tar.xz.drv'...

trying https://dist.torproject.org/torbrowser/11.5.1/tor-browser-linux64-11.5.1_en-US.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   266    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404

trying https://tor.eff.org/dist/torbrowser/11.5.1/tor-browser-linux64-11.5.1_en-US.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   146    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
curl: (22) The requested URL returned error: 404

trying https://tor.calyxinstitute.org/dist/torbrowser/11.5.1/tor-browser-linux64-11.5.1_en-US.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   146    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download tor-browser-linux64-11.5.1_en-US.tar.xz from any mirror
error: builder for '/nix/store/s0gv1j6fqzjzgr9kqvndhcgsmwivjzhi-tor-browser-linux64-11.5.1_en-US.tar.xz.drv' failed with exit code 1;
       last 10 log lines:
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0   146    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
       > curl: (22) The requested URL returned error: 404
       >
       > trying https://tor.calyxinstitute.org/dist/torbrowser/11.5.1/tor-browser-linux64-11.5.1_en-US.tar.xz
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0   146    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download tor-browser-linux64-11.5.1_en-US.tar.xz from any mirror
       For full logs, run 'nix log /nix/store/s0gv1j6fqzjzgr9kqvndhcgsmwivjzhi-tor-browser-linux64-11.5.1_en-US.tar.xz.drv'.
error: 1 dependencies of derivation '/nix/store/0faf1b6dnqisg7666hhrrn2hs16d9b93-tor-browser-bundle-bin-11.5.1.drv' failed to build

Additional context

Probably just has to be updated: https://tor.calyxinstitute.org/dist/torbrowser/

image

Notify maintainers

@offline @matejc @thoughtpolice @joachifm @hax404 @KarlJoad

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.59, NixOS, 22.05 (Quokka), 22.05.2889.67e45078141`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(root): `"nixos-22.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
@ghost ghost added the 0.kind: build failure label Sep 6, 2022
@bobby285271
Copy link
Member

I merged #189121 several days ago but looks like the channel is not updating for reasons™, anyway maybe we need to find a fallback download url.

@joachifm
Copy link
Contributor

joachifm commented Sep 7, 2022

This is a recurring issue with the bundle. I believe there are already a few fallback URLs but perhaps they all adhere to the policy of removing all but the latest release? I understand that upstream strongly prefers users always run the latest version.

To avoid build failures I suppose you could try re-enabling Hydra caching (if it's still disabled) but that incurs the risk of letting users run outdated versions for longer.

@ghost
Copy link

ghost commented Sep 21, 2022

To avoid build failures I suppose you could try re-enabling Hydra caching (if it's still disabled)

Why was it disabled? Maybe we should insert a comment with the explanation.

Depending on the reason for the disablement, #191492 may or may not eliminate whatever the benefit of disabling it being fetched+cached by Hydra was.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Sep 21, 2022

Why was it disabled? Maybe we should insert a comment with the explanation.

In ecd0e1a which delivers no good reason. Going to remove that. #192220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants