Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root: use pure CoreSymbolication on Darwin #128581

Merged
merged 1 commit into from
Jun 29, 2021
Merged

root: use pure CoreSymbolication on Darwin #128581

merged 1 commit into from
Jun 29, 2021

Conversation

thefloweringash
Copy link
Member

The current build works by linking against CoreSymbolication in
/System/Library/PrivateFrameworks. This is impure and doesn't work in
newer versions of macOS.

See #128576

Motivation for this change

Attempt at fixing #128576

Untested

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@thefloweringash
root: use pure CoreSymbolication on Darwin
55dcd99 
The current build works by linking against CoreSymbolication in
/System/Library/PrivateFrameworks. This is impure and doesn't work in
newer versions of macOS.

See NixOS#128576
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 29, 2021
@thefloweringash thefloweringash mentioned this pull request Jun 29, 2021
Closed
@ofborg ofborg bot requested a review from veprbl June 29, 2021 02:15
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jun 29, 2021
@domenkozar domenkozar marked this pull request as ready for review June 29, 2021 08:45
@domenkozar
Copy link
Member

Merging since it doesn't regress linux/darwin.

@domenkozar domenkozar merged commit e405361 into NixOS:master Jun 29, 2021
@thefloweringash thefloweringash deleted the fix-root-darwin-build branch June 29, 2021 09:42
@github-actions github-actions bot mentioned this pull request Jun 29, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #128673 for release-21.05.

@domenkozar
Copy link
Member

attribute 'CoreSymbolication' missing, at /build/source/pkgs/top-level/all-packages.nix:30409:57

@veprbl
Copy link
Member

veprbl commented Jun 30, 2021

@domenkozar Is that on aarch64-darwin?

@domenkozar
Copy link
Member

Yes, ofborg doesn't yet evaluate for that platform.

@domenkozar domenkozar mentioned this pull request Jun 30, 2021
Closed
vcunat added a commit that referenced this pull request Jul 5, 2021
@vcunat
root: fix evaluation on aarch64-darwin (/cc PR #128581)
c52d06b 
This fixes the tarball job in staging-next jobset
(there the platform is explicitly added).
The main problem right now would be the possibility of hiding
some other problems.
vcunat added a commit that referenced this pull request Jul 5, 2021
@vcunat
Revert "root: fix evaluation on aarch64-darwin (/cc PR #128581)"
e0ca027 
This reverts commit c52d06b.
It was no longer needed here; I missed merge f468ad4 (PR #129292).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thefloweringash @domenkozar @veprbl