-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
natron: 2.3.15 -> 2.4.0 #121212
natron: 2.3.15 -> 2.4.0 #121212
Conversation
Result of 1 package built successfully:
1 suggestion:
Result of 1 package failed to build:Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just cherry-pick the maintainer commit into this PR if you want.
@SuperSandro2000 I changed the ffmpeg and cherry-picked the maintainers commit. Reading @r-rmcgibbo's comment; do I understand this file correctly that I should update Natron's license to |
Not quite. That file is the same for both variants but the code contains a license header that mentions or later which means it is plus. |
Ah, I understand. Fortunately, that seems to be the case |
Based on upstream's commit 9ab1bb99430a2430e5b051d6313676188e23d584
@vojta001 please fix the build failure on arm64 |
@SuperSandro2000 I am afraid upstream doesn't support ARM yet NatronGitHub/Natron#277 |
@vojta001 please resolve the merge conflict. |
Done, if you don't mind a merge commit. I can rebase instead |
Oh, but it does not build then, |
@@ -1,21 +1,21 @@ | |||
{ lib, stdenv, fetchurl, qt4, pkg-config, boost, expat, cairo, python2Packages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove python2?
I marked this as stale due to inactivity. → More info |
@vojta001 please rebase to fix the merge conflict |
Neither Natron 2.3.15, nor Natron 2.4.0 can be built without Python 2, therefore I can't fix this PR. There is some hope though – Natron 2.5 should support Python 3 NatronGitHub/Natron#828 |
I would also like to add myself as a maintainer of Natron, however my commit to become a maintainer currently waits for #115189. Either wait for it to be merged or I'll open another PR for it soon.
Motivation for this change
Update
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)