mirage: 0.6.4 -> 0.7.0 #115189

vojta001 · 2021-03-05T13:59:03Z

Motivation for this change

Update Mirage to 0.7.0. To make this work, matrix-nio has to be updated as well, but I am struggling to do it (they began using Tox). Could you @tilpner, @emilazy and @symphorien, the maintainers of matrix-nio, have a look at it? Mirage can be built ATM, but does not work.

Things done

r-rmcgibbo · 2021-03-05T14:53:15Z

Result of nixpkgs-review pr 115189 at ec97688d run on x86_64-linux 1

10 packages built:

2 suggestions:

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

Near pkgs/applications/networking/instant-messengers/mirage/default.nix:54:5:
```
   |
54 |     license = licenses.lgpl3;
   |     ^
```

warning: unused-argument

Unused argument: qttools.
Near pkgs/applications/networking/instant-messengers/mirage/default.nix:3:55:

  |
3 | , qtbase, qtquickcontrols2, qtkeychain, qtmultimedia, qttools, qtgraphicaleffects
  |                                                       ^

Result of nixpkgs-review pr 115189 at ec97688d run on aarch64-linux 1

10 packages built:

2 suggestions:

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

Near pkgs/applications/networking/instant-messengers/mirage/default.nix:54:5:
```
   |
54 |     license = licenses.lgpl3;
   |     ^
```

warning: unused-argument

Unused argument: qttools.
Near pkgs/applications/networking/instant-messengers/mirage/default.nix:3:55:

  |
3 | , qtbase, qtquickcontrols2, qtkeychain, qtmultimedia, qttools, qtgraphicaleffects
  |                                                       ^

maintainers/maintainer-list.nix

pkgs/development/python-modules/hsluv/default.nix

pkgs/development/python-modules/plyer/default.nix

pkgs/development/python-modules/watchgod/default.nix

pkgs/top-level/python-packages.nix

symphorien · 2021-03-07T14:35:13Z

For matrix-nio, maybe you were stuck because you need to add format = "pyproject"
Here is what I have

diff --git a/pkgs/development/python-modules/matrix-nio/default.nix b/pkgs/development/python-modules/matrix-nio/default.nix
index 69774b58eb6..d14813bec21 100644
--- a/pkgs/development/python-modules/matrix-nio/default.nix
+++ b/pkgs/development/python-modules/matrix-nio/default.nix
@@ -5,6 +5,7 @@
 , attrs
 , future
 , aiohttp
+, aiohttp-socks
 , aiofiles
 , h11
 , h2
@@ -16,27 +17,32 @@
 , peewee
 , cachetools
 , atomicwrites
+, poetry-core
 }:
 
 buildPythonPackage rec {
   pname = "matrix-nio";
-  version = "0.15.2";
+  version = "0.17.0";
 
   src = fetchFromGitHub {
     owner = "poljar";
     repo = "matrix-nio";
     rev = version;
-    sha256 = "190xw3cvk4amr9pl8ip2i7k3xdjd0231kn2zl6chny5axx22p1dv";
+    sha256 = "sha256:0fdcbkrki5ni8aaq9xbrmpj1n7hf9z1vvi1b6jkzl55ahc0n50ki";
   };
 
   nativeBuildInputs = [
     git
+    poetry-core
   ];
 
+  format = "pyproject";
+
   propagatedBuildInputs = [
     attrs
     future
     aiohttp
+    aiohttp-socks
     aiofiles
     h11
     h2

but it's not finished because it needs newer dependencies all the way down. feel free to reuse this diff, as I won't make a PR very soon, it's not my priority right now.

vojta001 · 2021-03-08T12:24:21Z

@symphorien thanks a lot! I didn't know format = "pyproject" was a thing.

I used your diff as a base and continued the hunt. Paradoxically the dependencies are too new, so I came up with this

diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
index 9e7ee0a7a1a..c5efd2c70f5 100644
--- a/pkgs/top-level/python-packages.nix
+++ b/pkgs/top-level/python-packages.nix
@@ -4023,7 +4023,37 @@ in {
 
   matrix-client = callPackage ../development/python-modules/matrix-client { };
 
-  matrix-nio = callPackage ../development/python-modules/matrix-nio { };
+  matrix-nio = callPackage ../development/python-modules/matrix-nio {
+    aiofiles = self.aiofiles.overridePythonAttrs (old: rec {
+      version = "0.4.0";
+      src = old.src.override {
+        inherit version;
+        sha256 = "sha256-Ah6gujFKhgJ8Fm7MS0wH8tQPwPSzqVDRhooPJXHCu+4=";
+      };
+    });
+    h11 = self.h11.overridePythonAttrs (old: rec {
+      version = "0.9.0";
+      src = old.src.override {
+        inherit version;
+        sha256 = "sha256-M9S8p74PoDn06E1QqwBTEEflPW7o/7yDUB6mAsFpyuE=";
+      };
+    });
+    h2 = (self.h2.overridePythonAttrs (old: rec {
+      version = "3.2.0";
+      src = old.src.override {
+        inherit version;
+        sha256 = "sha256-h19B69byxEeBJZAFsVf67RpQMd865ap7y0YopsB4LxQ=";
+      };
+    })).override {
+      hpack = self.hpack.overridePythonAttrs (old: rec {
+        version = "3.0.0";
+        src = old.src.override {
+          inherit version;
+          sha256 = "sha256-juycH0v640CKPzBQAmH35qZZEtwThSbqBU+a2YiS6dI=";
+        };
+      });
+    };
+  };
 
   mautrix = callPackage ../development/python-modules/mautrix { };

I don't know Nix/nixpkgs enough. matrix-nio's dependency h2, when downgraded, requires a downgraded hpack. I tried it with the override call, but it doesn't work. How do I override a dependency of a dependency?

vojta001 · 2021-03-09T10:33:09Z

Result of nixpkgs-review pr 115189 run on x86_64-linux 1

1 package failed to build:

pantalaimon

12 packages built:

electrum
mirage-im
python38Packages.aiohttp-socks
python38Packages.hsluv
python38Packages.matrix-nio
python38Packages.plyer
python38Packages.python-socks
python38Packages.watchgod
python39Packages.hsluv
python39Packages.plyer
python39Packages.watchgod
weechatScripts.weechat-matrix

vojta001 · 2021-03-09T10:50:41Z

Result of nixpkgs-review pr 115189 run on x86_64-linux 1

13 packages built:

electrum
mirage-im
pantalaimon
python38Packages.aiohttp-socks
python38Packages.hsluv
python38Packages.matrix-nio
python38Packages.plyer
python38Packages.python-socks
python38Packages.watchgod
python39Packages.hsluv
python39Packages.plyer
python39Packages.watchgod
weechatScripts.weechat-matrix

@symphorien

Co-authored-by: @symphorien

vojta001 · 2021-03-09T11:11:19Z

@colemickens Now it builds and I resolved all stylistic suggestions

SuperSandro2000 · 2021-03-10T19:42:54Z

pkgs/applications/networking/instant-messengers/pantalaimon/default.nix

  };

+  patches = [ ./update-matrix-nio.patch ];


Please use substituteInPlace instead.

symphorien · 2021-03-10T20:11:45Z

mirage works.

About updating the dependencies of matrix-nio: I asked upstream matrix-nio/matrix-nio#249 In the past they have been pretty responsive.

SuperSandro2000 · 2021-03-10T22:49:04Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115189 run on x86_64-linux 1

13 packages built:

electrum
mirage-im
pantalaimon
python38Packages.aiohttp-socks
python38Packages.hsluv
python38Packages.matrix-nio
python38Packages.plyer
python38Packages.python-socks
python38Packages.watchgod
python39Packages.hsluv
python39Packages.plyer
python39Packages.watchgod
weechatScripts.weechat-matrix

risicle · 2021-03-14T19:00:18Z

pkgs/development/python-modules/matrix-nio/default.nix

  ];

+  patches = [ ./update-dependencies.patch ];
+


This could also do with being a substituteInPlace, and there's often little point in bumping it up to a specific version as it just means the next person will have to manually bump the bumps next time a dependency is bumped in nixpkgs. Does it work if you switch them all to = "*"?

Also it would be nice to have a go at enabling some of the tests (or at least a pythonImportsCheck) if we're going to be messing with the dependencies now.

risicle · 2021-03-14T19:01:20Z

nixpkgs-review is happy on macos 10.14 FWIW

fixes the build of pantalaimon

symphorien · 2021-03-20T18:09:40Z

This breaks pantalaimon. I provide a fix in ee15c78
wrt enabling test for matrix-nio as suggested by @risicle here is a fix: c48af03

It seems you haven't ticked the box allowing me to push these directly to your PR so you'll have to pick these commits by hand.

SuperSandro2000 · 2021-04-29T23:01:05Z

pkgs/development/python-modules/python-socks/default.nix

+  };
+
+  checkInputs = [ trio curio async-timeout ];
+


Suggested change

pythonImportsCheck = [ "python_socks" ];

SuperSandro2000 · 2021-04-29T23:01:16Z

pkgs/development/python-modules/plyer/default.nix

+    sha256 = "sha256-jeOLF7xDjfNu7erNVGzwUwOrhxhVrwZp/E6N9R8q35Q=";
+  };
+
+  doCheck = false; # tests fail in Nix sandbox


How does it fail?

If I add keyring as a check input, it fails with the following. I don't understand the internals, but passing in xbacklight does not help.

@nix { "action": "setPhase", "phase": "setuptoolsCheckPhase" } setuptoolsCheckPhase Executing setuptoolsCheckPhase running test WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. running egg_info writing plyer.egg-info/PKG-INFO writing dependency_links to plyer.egg-info/dependency_links.txt writing requirements to plyer.egg-info/requires.txt writing top-level names to plyer.egg-info/top_level.txt reading manifest file 'plyer.egg-info/SOURCES.txt' reading manifest template 'MANIFEST.in' warning: no files found matching '*README.rst' writing manifest file 'plyer.egg-info/SOURCES.txt' running build_ext Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.audio' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.barometer' upower not found.Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.bluetooth' sh: which: not found Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 94, in _ensure_obj obj = mod.instance() File "/build/plyer-2.0.0/plyer/platforms/linux/brightness.py", line 29, in instance return LinuxBrightness() File "/build/plyer-2.0.0/plyer/platforms/linux/brightness.py", line 18, in __init__ raise Exception(msg) Exception: It looks like 'xbacklight' is not installed. Try installing it with your distribution's package manager. Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.call' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.camera' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.compass' xdg-open not found.Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.flash' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.gps' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.gravity' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.gyroscope' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.humidity' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.irblaster' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.light' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.proximity' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.sms' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.spatialorientation' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.stt' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.temperature' lshw not found.Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') ModuleNotFoundError: No module named 'plyer.platforms.linux.vibrator' Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/platforms/linux/wifi.py", line 13, in <module> import wifi ModuleNotFoundError: No module named 'wifi' The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/utils.py", line 93, in _ensure_obj mod = __import__(module, fromlist='.') File "/build/plyer-2.0.0/plyer/platforms/linux/wifi.py", line 15, in <module> raise ModuleNotFoundError( ModuleNotFoundError: python-wifi not installed. try: `pip install --user wifi`. Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/platforms/win/uniqueid.py", line 6, in <module> import _winreg as regedit ModuleNotFoundError: No module named '_winreg' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/build/plyer-2.0.0/plyer/platforms/win/uniqueid.py", line 9, in <module> import winreg as regedit ModuleNotFoundError: No module named 'winreg' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "nix_run_setup", line 8, in <module> exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec')) File "setup.py", line 56, in <module> setup( File "/nix/store/z9rg0ff8qdmvg7v83fq0ixzp2vlpl3fl-python3.8-setuptools-50.3.1/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup return distutils.core.setup(**attrs) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/distutils/core.py", line 148, in setup dist.run_commands() File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/distutils/dist.py", line 966, in run_commands self.run_command(cmd) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/distutils/dist.py", line 985, in run_command cmd_obj.run() File "/nix/store/z9rg0ff8qdmvg7v83fq0ixzp2vlpl3fl-python3.8-setuptools-50.3.1/lib/python3.8/site-packages/setuptools/command/test.py", line 232, in run self.run_tests() File "/nix/store/z9rg0ff8qdmvg7v83fq0ixzp2vlpl3fl-python3.8-setuptools-50.3.1/lib/python3.8/site-packages/setuptools/command/test.py", line 250, in run_tests test = unittest.main( File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/main.py", line 100, in __init__ self.parseArgs(argv) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/main.py", line 124, in parseArgs self._do_discovery(argv[2:]) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/main.py", line 244, in _do_discovery self.createTests(from_discovery=True, Loader=Loader) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/main.py", line 154, in createTests self.test = loader.discover(self.start, self.pattern, self.top) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/loader.py", line 349, in discover tests = list(self._find_tests(start_dir, pattern)) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/loader.py", line 405, in _find_tests tests, should_recurse = self._find_test_path( File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/loader.py", line 483, in _find_test_path tests = self.loadTestsFromModule(package, pattern=pattern) File "/nix/store/z9rg0ff8qdmvg7v83fq0ixzp2vlpl3fl-python3.8-setuptools-50.3.1/lib/python3.8/site-packages/setuptools/command/test.py", line 50, in loadTestsFromModule tests.append(self.loadTestsFromName(submodule)) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/loader.py", line 191, in loadTestsFromName return self.loadTestsFromModule(obj) File "/nix/store/z9rg0ff8qdmvg7v83fq0ixzp2vlpl3fl-python3.8-setuptools-50.3.1/lib/python3.8/site-packages/setuptools/command/test.py", line 50, in loadTestsFromModule tests.append(self.loadTestsFromName(submodule)) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/loader.py", line 191, in loadTestsFromName return self.loadTestsFromModule(obj) File "/nix/store/z9rg0ff8qdmvg7v83fq0ixzp2vlpl3fl-python3.8-setuptools-50.3.1/lib/python3.8/site-packages/setuptools/command/test.py", line 50, in loadTestsFromModule tests.append(self.loadTestsFromName(submodule)) File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/unittest/loader.py", line 154, in loadTestsFromName module = __import__(module_name) File "/build/plyer-2.0.0/plyer/platforms/win/uniqueid.py", line 11, in <module> raise NotImplementedError() NotImplementedError

That does not look good. Did you check if the module still works?

SuperSandro2000 · 2021-04-29T23:01:45Z

pkgs/development/python-modules/matrix-nio/default.nix

+    "test_connect_wrapper"
+    # time dependent and flaky
+    "test_transfer_monitor_callbacks"
+  ];



Suggested change

pythonImportsCheck = [ "nio" ];

Oh one can have both normal checks and pythonImportsCheck? TIL

vojta001 added 4 commits March 5, 2021 14:49

maintainers: add vojta001

f159ac6

pythonPackages.plyer: init at 2.0.0

90df4f7

pythonPackages.hsluv: init at 5.0.2

3b8ff6e

pythonPackages.watchgod: init at 0.7

0d5b41c

ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package labels Mar 5, 2021

ofborg bot requested a review from colemickens March 5, 2021 14:08

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 5, 2021

SuperSandro2000 requested changes Mar 5, 2021

View reviewed changes

vojta001 force-pushed the mirage branch from ec97688 to 8e431c1 Compare March 9, 2021 10:25

ofborg bot added the 8.has: clean-up label Mar 9, 2021

ofborg bot requested review from tilpner, symphorien and emilazy March 9, 2021 10:36

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 9, 2021

ofborg bot requested a review from Valodim March 9, 2021 10:56

vojta001 added 5 commits March 9, 2021 12:01

pythonPackages.python-socks: init at 1.2.2

0a13e98

pythonPackages.aiohttp-socks: 0.3.9 -> 0.6.0

bce791b

pythonPackages.matrix-nio: 0.15.2 -> 0.17.0

7c887b7

Co-authored-by: @symphorien

mirage: 0.6.4 -> 0.7.0

47824c1

pantalaimon: 0.8.0 -> 0.9.1

5656392

vojta001 force-pushed the mirage branch from 0fa628c to 5656392 Compare March 9, 2021 11:05

vojta001 requested a review from SuperSandro2000 March 9, 2021 11:10

vojta001 marked this pull request as ready for review March 9, 2021 11:11

vojta001 requested review from FRidh and jonringer as code owners March 9, 2021 11:11

SuperSandro2000 reviewed Mar 10, 2021

View reviewed changes

risicle reviewed Mar 14, 2021

View reviewed changes

symphorien added 2 commits March 20, 2021 19:08

python3.pkgs.aioresponses: 0.7.1 -> 0.7.2

ee15c78

fixes the build of pantalaimon

python3.pkgs.matrix-nio: enable tests

c48af03

vojta001 mentioned this pull request Apr 29, 2021

natron: 2.3.15 -> 2.4.0 #121212

Closed

10 tasks

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 29, 2021

SuperSandro2000 reviewed Apr 29, 2021

View reviewed changes

siraben closed this Jul 26, 2021

vojta001 deleted the mirage branch March 14, 2022 11:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mirage: 0.6.4 -> 0.7.0 #115189

mirage: 0.6.4 -> 0.7.0 #115189

vojta001 commented Mar 5, 2021 •

edited

Loading

r-rmcgibbo commented Mar 5, 2021 •

edited

Loading

symphorien commented Mar 7, 2021

vojta001 commented Mar 8, 2021

vojta001 commented Mar 9, 2021 •

edited

Loading

vojta001 commented Mar 9, 2021

vojta001 commented Mar 9, 2021

SuperSandro2000 Mar 10, 2021

symphorien commented Mar 10, 2021

SuperSandro2000 commented Mar 10, 2021

risicle Mar 14, 2021

risicle commented Mar 14, 2021

symphorien commented Mar 20, 2021

SuperSandro2000 Apr 29, 2021

SuperSandro2000 Apr 29, 2021

vojta001 Apr 30, 2021

SuperSandro2000 Apr 30, 2021

SuperSandro2000 Apr 29, 2021

symphorien Apr 30, 2021

mirage: 0.6.4 -> 0.7.0 #115189

mirage: 0.6.4 -> 0.7.0 #115189

Conversation

vojta001 commented Mar 5, 2021 • edited Loading

Motivation for this change

Things done

r-rmcgibbo commented Mar 5, 2021 • edited Loading

symphorien commented Mar 7, 2021

vojta001 commented Mar 8, 2021

vojta001 commented Mar 9, 2021 • edited Loading

vojta001 commented Mar 9, 2021

vojta001 commented Mar 9, 2021

Choose a reason for hiding this comment

symphorien commented Mar 10, 2021

SuperSandro2000 commented Mar 10, 2021

Choose a reason for hiding this comment

risicle commented Mar 14, 2021

symphorien commented Mar 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vojta001 commented Mar 5, 2021 •

edited

Loading

r-rmcgibbo commented Mar 5, 2021 •

edited

Loading

vojta001 commented Mar 9, 2021 •

edited

Loading