Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn2nix: updates from nix-community/yarn2nix #108138

Merged
merged 3 commits into from
May 20, 2021

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Jan 1, 2021

I have not tested this, but code looked fine to me.

We still need to close down the old repo and notify everybody that development/contributions should now happen here.

@SuperSandro2000
Copy link
Member

The second commit is not prefetched with yarn2nix.

@flokli
Copy link
Contributor

flokli commented Jan 2, 2021

@Lassulus how can this be tested?

@Lassulus
Copy link
Member Author

@flokli just using it? I don't know. but if the nix-community/yarn2nix works for you I don't see why this shouldn't. I just fixed it because I wanted to package workadventure and it worked fine for that usecase.

@flokli
Copy link
Contributor

flokli commented Apr 29, 2021

alright, SGTM.

@Lassulus Lassulus merged commit c03bb4d into NixOS:master May 20, 2021
@Profpatsch
Copy link
Member

I’m trying to link to this from my yarn2nix’s Readme, but it look like there is no readme, no manual section, nothing documenting this tool. What do?

@Profpatsch
Copy link
Member

Like, the code is here but no readme: https://github.com/NixOS/nixpkgs/tree/master/pkgs/development/tools/yarn2nix-moretea/yarn2nix

And grepping through the nixpkgs manual there is no mention of yarn2nix I can see.

@GuillaumeDesforges
Copy link
Contributor

For anyone falling there in the future, check out the manual https://nixos.org/manual/nixpkgs/stable/#javascript-yarn2nix

@sielicki
Copy link
Contributor

sielicki commented Feb 9, 2023

Hate to be that guy but the old repo was licensed GPL3, so what's the license under nixpkgs for this?

@Lassulus
Copy link
Member Author

I guess still GPL3? but I dunno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants