-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn2nix: Handle codeload.github.com tarballs #107979
Conversation
That makes sense to me -- how do you think we should do that @zimbatm @flokli (others? https://github.com/nix-community/yarn2nix has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me modulus the newline change
This was submitted originally in nix-community/yarn2nix#130
6d67479
to
32c9918
Compare
I think we already had the same conversation in another issue. I would be in favour of having everything in nixpkgs, or everything in this repo, but not on both sides. |
I think the reason it's inside nixpkgs is, because for the mkYarnPackage/mkYarnPlatform etc. functions. If we would want to use them in nixpkgs they need to be part of the repo. So I would vote to change the nix-community repo to read only and merge the remaining additions inside nixpkgs. |
Sounds good to me! |
I have a created a PR for moving the remaining changes (its just one and a yarn update) inside nixpkgs: |
This was submitted originally in nix-community/yarn2nix#130
I find it very confusing, that there is a yarn2nix repo in the nix-community project and the same code is duplicated inside nixpkgs. Especially if these code bases diverge, Maybe it would be cooler to have them in just one location (nixpkgs?)