Make circuits and assignment tables: CI implementation #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickVolynkin
force-pushed
the
test-workflows-in-ci
branch
24 times, most recently
from
b97f853 to
21b2ccf
Compare
Dependency on crypto3::blueprint in zk/marshalling was causing the following error: ``` CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library): Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? ``` Resolves #22
NickVolynkin
force-pushed
the
test-workflows-in-ci
branch
3 times, most recently
from
587b616 to
35bccfc
Compare
NickVolynkin
force-pushed
the
test-workflows-in-ci
branch
5 times, most recently
from
c8753f3 to
a4ec8a3
Compare
NickVolynkin
changed the title
NickVolynkin
force-pushed
the
test-workflows-in-ci
branch
from
a4ec8a3 to
e97c5fc
Compare
NickVolynkin
changed the title
NickVolynkin
changed the title
NickVolynkin
changed the title
Script `./scripts/build-circuit-ll.sh` runs in an environment with zkLLVM. First, it builds the LLVM-IR form or circuit (`.ll`) with zkLLVM CLI. Next, it builds the assignment table `.tbl` and circuit `.crct` with assigner CLI. Script `scripts/docker-run.sh` runs the first one in a container based on a prebuilt image `ghcr.io/nilfoundation/zkllvm-template`, that has all required dependencies, in particular, zkLLVM and Boost. Script uses Podman when it is available, and Docker otherwise. Using separate scripts (rather than `run` steps in CI) enables testing the same workflow locally with a single command. CI runs on default GitHub's `ubuntu-22.04` runners so that devs who fork this repository would still have CI working in their forks. Resolves #5
NickVolynkin
force-pushed
the
test-workflows-in-ci
branch
from
e97c5fc to
a2aa20b
Compare
nkaskov
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make circuits and assignment tables: CI implementation
Changes in the tutorial will follow this PR (see #4)
ci: build circuit and assignment table
Script
./scripts/build-circuit-ll.shruns in an environment with zkLLVM.First, it builds the LLVM-IR form or circuit (
.ll) with zkLLVM CLI.Next, it builds the assignment table
.tbland circuit.crctwithassigner CLI.
Script
scripts/docker-run.shruns the first one in a container basedon a prebuilt image
ghcr.io/nilfoundation/zkllvm-template,that has all required dependencies, in particular, zkLLVM and Boost.
Script uses Podman when it is available, and Docker otherwise.
Using separate scripts (rather than
runsteps in CI) enables testingthe same workflow locally with a single command.
CI runs on default GitHub's
ubuntu-22.04runners so that devs who forkthis repository would still have CI working in their forks.
Resolves #5
Remove blueprint dependency from crypto3/marshalling/zk
Dependency on crypto3::blueprint in zk/marshalling was causing
the following error:
Resolves #22
Crypto3: support optional Boost static library usage
Related to NilFoundation/zkLLVM#85
Revert commits related to #14
This reverts commits:
Resolves #24