Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot test circuit based on sha256 #22

Closed
color-typea opened this issue Jun 5, 2023 · 0 comments · Fixed by #23
Closed

Cannot test circuit based on sha256 #22

color-typea opened this issue Jun 5, 2023 · 0 comments · Fixed by #23

Comments

@color-typea
Copy link
Contributor

Example with minimal changes compared to template master branch:
https://github.com/color-typea/lido-zkllvm-accounting-curcuit/tree/minimal_setup_with_tests_and_crypto3

Steps to reproduce:
See README.md on the branch, but essentially just

cmake -DBUILD_TESTS=TRUE -S . -B ./build && cmake --build ./build --target test

Expected outcome:

  • test/lib.cpp is compiled and run.
  • test_sum pass (100% sure it will... Ok, 99%)
  • test_balance might pass (not 100% sure the "supporting" code is implemented correctly)

Actual outcome:

CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/CMakeLists.txt:24 (add_library)

Success criteria: it is possible to write and run tests against code using crypto3::sha256
@NickVolynkin NickVolynkin mentioned this issue Jun 6, 2023
Merged
NickVolynkin added a commit to NilFoundation/crypto3 that referenced this issue Jun 6, 2023
@NickVolynkin
Update marshalling/zk: remove blueprint dependency
a8184c6 
Dependency on crypto3::blueprint in zk/marshalling was
resulting in the following error:

```
CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
```

Part of NilFoundation/zkllvm-template#22
@NickVolynkin NickVolynkin mentioned this issue Jun 6, 2023
Merged
NickVolynkin added a commit to NilFoundation/crypto3 that referenced this issue Jun 6, 2023
@NickVolynkin
Update zk-marshalling: remove blueprint dependency
60dfd75 
Dependency on crypto3::blueprint in zk/marshalling was
resulting in the following error:

```
CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
```

Part of NilFoundation/zkllvm-template#22
NickVolynkin added a commit to NilFoundation/crypto3 that referenced this issue Jun 6, 2023
@NickVolynkin
Update zk-marshalling: remove blueprint dependency
2c53f05 
Dependency on crypto3::blueprint in zk/marshalling was
causing the following error:

```
CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
```

Part of NilFoundation/zkllvm-template#22
NickVolynkin added a commit that referenced this issue Jun 6, 2023
@NickVolynkin
Remove blueprint dependency from crypto3/marshalling/zk
f3041a4 
Dependency on crypto3::blueprint in zk/marshalling was causing
the following error:

```
CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
```

Resolves #22
NickVolynkin added a commit that referenced this issue Jun 6, 2023
@NickVolynkin
Remove blueprint dependency from crypto3/marshalling/zk
9cbf5eb 
Dependency on crypto3::blueprint in zk/marshalling was causing
the following error:

```
CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
```

Resolves #22
NickVolynkin added a commit to NilFoundation/crypto3 that referenced this issue Jun 6, 2023
@NickVolynkin
Update zk-marshalling: remove blueprint dependency
afd0925 
Dependency on crypto3::blueprint in zk/marshalling was
causing the following error:

```
CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
```

Part of NilFoundation/zkllvm-template#22
NickVolynkin added a commit that referenced this issue Jun 12, 2023
@NickVolynkin
Remove blueprint dependency from crypto3/marshalling/zk
a6ffa60 
Dependency on crypto3::blueprint in zk/marshalling was causing
the following error:

```
CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
```

Resolves #22
NickVolynkin added a commit that referenced this issue Jun 12, 2023
@NickVolynkin
Remove blueprint dependency from crypto3/marshalling/zk
b24da8a 
Dependency on crypto3::blueprint in zk/marshalling was causing
the following error:

```
CMake Error at cmake/modules/share/modules/cmake/CMFuture.cmake:83 (_add_library):
  Target "zkllvm_circuit" links to target "crypto3::blueprint" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
```

Resolves #22
@NickVolynkin NickVolynkin mentioned this issue Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make circuits and assignment tables: CI implementation NilFoundation/zkllvm-template
1 participant
@color-typea