Likely.initiate breaks counters of existing widgets #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks! Will check this today. |
| @@ -62,7 +62,7 @@ Likely.prototype = { | |||
| update: function (options) { | |||
| if ( | |||
| options.forceUpdate || | |||
| options.url !== this.options.url | |||
| options.url && options.url !== this.options.url | |||
There was a problem hiding this comment.
Doesn’t it work the same? I.e.
| options.url | this.options.url | expression | result |
|---|---|---|---|
| undefined | "ilyabirman.ru" | false && false | false |
| "ilyabirman.net" | "ilyabirman.ru" | true && false | false |
| "ilyabirman.ru" | "ilyabirman.ru" | true && true | true |
The first two lines always result into false, so the additional options.url check doesn’t matter. Am I wrong?
There was a problem hiding this comment.
let's substitute the values:
// options.url === undefined
// false, `cause the first operand
undefined && undefined !== 'some-default-url'
// true, `cause undefined literally doesn't equal the string
undefined !== 'some-default-url'There was a problem hiding this comment.
In another words: false || false && true => false (don't forget about priority of the operations, first && and then ||, so we don't need extra parenthesis)
There was a problem hiding this comment.
Ah, yes, !==, not ===. You’re right.
|
Cool! Tested on journal.tinkoff.ru, seems to work. Thank you! |
|
Happy to be involved in development of journal.tinkoff.ru 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If options for update method are not specified, it will be empty object.
{}.urlnever equalsthis.options.url, so the buttons try to reinit.What happens next? Counters are being updated, and call the fetch method, which doesn't do anything if there's a corresponding counter and there's no force update. So the counters vanish.