Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likely.initiate breaks counters of existing widgets #83

Closed
vitkarpov opened this issue Aug 9, 2016 · 5 comments
Closed

Likely.initiate breaks counters of existing widgets #83

vitkarpov opened this issue Aug 9, 2016 · 5 comments
Assignees
@vitkarpov
Labels
Bug

Comments

@vitkarpov
Copy link
Collaborator

vitkarpov commented Aug 9, 2016 •
edited
Loading

Steps to reproduce

  • load the test page
  • perform likely.initiate() in console

Actual

Counters disappeared

Expected

Counters stay the same as after init
@vitkarpov vitkarpov added the Bug label Aug 9, 2016
@vitkarpov vitkarpov self-assigned this Aug 9, 2016
@vitkarpov vitkarpov mentioned this issue Aug 9, 2016
Closed
vitkarpov added a commit that referenced this issue Aug 9, 2016
@vitkarpov
[#83] Likely.initiate breaks counters of existing widgets
d057f44
@iamakulov
Copy link
Collaborator

As mentioned in #81 (comment), this is probably related to #75.

@vitkarpov
Copy link
Collaborator Author

vitkarpov commented Aug 9, 2016 •
edited
Loading

Should check after merge, but as I get right the description of #75, I can't grasp how it could be connected for the first sight.

@iamakulov
Copy link
Collaborator

I didn’t write that, but the larger problem with #75 was that the counters got broken after calling likely.initiate(). The issue is about History API because it was reproduced with History first, and the History changes were handled by calling likely.initiate().

@vitkarpov
Copy link
Collaborator Author

Ah, get it now. Will see anyway :)

iamakulov pushed a commit that referenced this issue Aug 11, 2016
@vitkarpov @iamakulov
[#83] Likely.initiate breaks counters of existing widgets (#84)
497562a 
Closes #84.
@vitkarpov
Copy link
Collaborator Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitkarpov vitkarpov

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamakulov @vitkarpov