Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some new translation keys #3716

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Oct 13, 2024

I looked at the screenshots here: #3715

And have taken the ones I thought would make sense to translate. I have left a few that I was not sure about.

I have not made any change to the original English text except one. There was Android 6 + in one. I deleted that portion since we have now retired Android 6.

Please let me know what you think. Thanks


The following images mark all the text that this PR moves to strings.
Screenshot_20241107-165154 Screenshot_20241107-165247 Screenshot_20241107-165406 Screenshot_20241107-170041 Screenshot_20241107-170139

@DiBochev
Copy link

DiBochev commented Nov 7, 2024

Hello,
about #3589 this is already merged in master branch, bu there are no new string for translation in crowdin.
@Navid200 @olorinmaia could you please verify that everithing is ok? I am currently trying to find those text in crowdin in order to translate them in bulgarian, but no luck.
I am looking forward to add new bulgarian texts to our collection :)
Thank you in advance.

@Navid200
Copy link
Collaborator Author

Navid200 commented Nov 7, 2024

@DiBochev This PR is not merged. Please be patient

@olorinmaia
Copy link
Contributor

I closed #3589 because I need to rework it a bit. Will set up a new PR once this one is merged.

@jamorham jamorham merged commit 0cf8d8f into NightscoutFoundation:master Dec 17, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2024_10_13 branch December 17, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants