-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-4844-Pectra: Blob gas fee collection for Gnosis #6866
Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
276d214
burn blob gas fees, rename price to fee
Marchhill c65c172
add test that blob gas fee burned / collected
Marchhill 6b437d3
compute blob gas once, check burned funds added to fee collector
Marchhill 11fd256
change blob gas price names to be clearer
Marchhill 1d167f4
timestamp enabled fork
Marchhill 83d0153
load transition timestamp from chainspec config
Marchhill ee888bd
merge master
Marchhill 824a5d1
Merge branch 'master' of github.com:NethermindEth/nethermind into fix…
Marchhill 43656ca
use nameof Barnet
Marchhill 1d291dc
merge master
Marchhill 62f450c
move to prague fork
Marchhill 36472af
add to all chainspec loaders and rename to EIP4844-Pectra
Marchhill 8d58ca1
fix whitespace
Marchhill 76f5d0d
prague specs in test
Marchhill 8c5c77e
merge master
Marchhill 28dd715
rename eip1559feecollector to feecollector
Marchhill fd2148d
Merge remote-tracking branch 'upstream/master' into fix/blob-fee-coll…
Marchhill b168a55
uint256 zero
Marchhill 9c605fa
rename pectra to feecollector, refactor collection/burning
Marchhill 919ec8d
separate gnosis prague instance
Marchhill 0b114c3
use gnosisprague instance in test
Marchhill d31b965
separate gnosis forks
Marchhill 75ffc3b
add gnosisforks folder
Marchhill cea59ea
Merge remote-tracking branch 'upstream/master' into fix/blob-fee-coll…
Marchhill 7168da7
praguegnosis instance
Marchhill 9a53e38
merge master
Marchhill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
praguegnosis instance
- Loading branch information
commit 7168da745101f32b82d64c92bcf65ebee9b055a3
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
src/Nethermind/Nethermind.Specs/GnosisForks/18_PragueGnosis.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,19 @@ | ||
// SPDX-FileCopyrightText: 2024 Demerzel Solutions Limited | ||
// SPDX-License-Identifier: LGPL-3.0-only | ||
|
||
using System.Threading; | ||
using Nethermind.Core.Specs; | ||
|
||
namespace Nethermind.Specs.GnosisForks; | ||
|
||
public class PragueGnosis : Forks.Prague | ||
{ | ||
private static IReleaseSpec _instance; | ||
|
||
protected PragueGnosis() : base() | ||
{ | ||
IsEip4844FeeCollectorEnabled = true; | ||
} | ||
|
||
public new static IReleaseSpec Instance => LazyInitializer.EnsureInitialized(ref _instance, () => new PragueGnosis()); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need
PragueLondon
to enable1559Collector
andFeeCollector
address? (Then more useful is to useOverridableReleaseSpec
than just inheritance)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what
PragueLondon
is? InOverridableReleaseSpec
it says it's for testing purposes onlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry
LondonGnosis