Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4844-Pectra: Blob gas fee collection for Gnosis #6866

Merged
merged 26 commits into from
Oct 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
276d214
burn blob gas fees, rename price to fee
Marchhill Mar 26, 2024
c65c172
add test that blob gas fee burned / collected
Marchhill Mar 26, 2024
6b437d3
compute blob gas once, check burned funds added to fee collector
Marchhill Mar 28, 2024
11fd256
change blob gas price names to be clearer
Marchhill Apr 2, 2024
1d167f4
timestamp enabled fork
Marchhill Apr 8, 2024
83d0153
load transition timestamp from chainspec config
Marchhill Apr 9, 2024
ee888bd
merge master
Marchhill Apr 15, 2024
824a5d1
Merge branch 'master' of github.com:NethermindEth/nethermind into fix…
Marchhill Apr 15, 2024
43656ca
use nameof Barnet
Marchhill Apr 15, 2024
1d291dc
merge master
Marchhill Sep 12, 2024
62f450c
move to prague fork
Marchhill Sep 12, 2024
36472af
add to all chainspec loaders and rename to EIP4844-Pectra
Marchhill Sep 12, 2024
8d58ca1
fix whitespace
Marchhill Sep 12, 2024
76f5d0d
prague specs in test
Marchhill Sep 12, 2024
8c5c77e
merge master
Marchhill Sep 26, 2024
28dd715
rename eip1559feecollector to feecollector
Marchhill Sep 26, 2024
fd2148d
Merge remote-tracking branch 'upstream/master' into fix/blob-fee-coll…
Marchhill Sep 26, 2024
b168a55
uint256 zero
Marchhill Sep 26, 2024
9c605fa
rename pectra to feecollector, refactor collection/burning
Marchhill Sep 26, 2024
919ec8d
separate gnosis prague instance
Marchhill Sep 26, 2024
0b114c3
use gnosisprague instance in test
Marchhill Sep 26, 2024
d31b965
separate gnosis forks
Marchhill Sep 26, 2024
75ffc3b
add gnosisforks folder
Marchhill Sep 26, 2024
cea59ea
Merge remote-tracking branch 'upstream/master' into fix/blob-fee-coll…
Marchhill Sep 26, 2024
7168da7
praguegnosis instance
Marchhill Sep 26, 2024
9a53e38
merge master
Marchhill Oct 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
praguegnosis instance
  • Loading branch information
Marchhill committed Sep 26, 2024
commit 7168da745101f32b82d64c92bcf65ebee9b055a3
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
// SPDX-FileCopyrightText: 2024 Demerzel Solutions Limited
// SPDX-License-Identifier: LGPL-3.0-only

using System.Threading;
using Nethermind.Core.Specs;

namespace Nethermind.Specs.GnosisForks;

public class PragueGnosis : Forks.Prague
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need PragueLondon to enable 1559Collector and FeeCollector address? (Then more useful is to use OverridableReleaseSpec than just inheritance)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what PragueLondon is? In OverridableReleaseSpec it says it's for testing purposes only

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry LondonGnosis

{
private static IReleaseSpec _instance;

protected PragueGnosis() : base()
{
IsEip4844FeeCollectorEnabled = true;
}

public new static IReleaseSpec Instance => LazyInitializer.EnsureInitialized(ref _instance, () => new PragueGnosis());
}