Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-4844-Pectra: Blob gas fee collection for Gnosis #6866

Merged
merged 26 commits into from
Oct 1, 2024
Merged

EIP-4844-Pectra: Blob gas fee collection for Gnosis #6866

merged 26 commits into from
Oct 1, 2024

Conversation

Marchhill
Copy link
Contributor

@Marchhill Marchhill commented Mar 26, 2024 •
edited
Loading

Changes

Implements gnosischain/specs#51

  • Blob gas fees are included in burnt fees or collected fees (depending on if chain has an EIP 1559 fee collector)
  • Can be triggered at a certain timestamp
  • Rename blob gas price to fee for clarity
  • Rename Eip1559FeeCollector to FeeCollector
  • Burnt fees recorded in tracing

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Needs changes to hive tests.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@Marchhill Marchhill requested a review from flcl42 March 26, 2024 11:00
@flcl42
Copy link
Contributor

flcl42 commented Apr 2, 2024

Btw the functionality requires a fork and can't merged without it

@LukaszRozmej
Copy link
Member

Btw the functionality requires a fork and can't merged without it

Right! We need a chainspec timestamp activation flag for it then!

@MarekM25 MarekM25 requested a review from LukaszRozmej April 5, 2024 22:39
LukaszRozmej
LukaszRozmej reviewed Apr 15, 2024
View reviewed changes
src/Nethermind/Chains/chiado.json Outdated Show resolved Hide resolved
src/Nethermind/Chains/gnosis.json Outdated Show resolved Hide resolved
@Marchhill Marchhill mentioned this pull request Sep 10, 2024
Merged
@Marchhill Marchhill changed the title Blob gas fee collection for Gnosis EIP-4844-B: Blob gas fee collection for Gnosis Sep 10, 2024
@Marchhill Marchhill changed the title EIP-4844-B: Blob gas fee collection for Gnosis EIP-4844-Pectra: Blob gas fee collection for Gnosis Sep 12, 2024
@Marchhill Marchhill marked this pull request as ready for review September 26, 2024 12:11
LukaszRozmej
LukaszRozmej approved these changes Sep 30, 2024
View reviewed changes
src/Nethermind/Nethermind.Specs/GnosisForks/18_PragueGnosis.cs

namespace Nethermind.Specs.GnosisForks;

public class PragueGnosis : Forks.Prague
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need PragueLondon to enable 1559Collector and FeeCollector address? (Then more useful is to use OverridableReleaseSpec than just inheritance)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what PragueLondon is? In OverridableReleaseSpec it says it's for testing purposes only

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry LondonGnosis

@Marchhill Marchhill merged commit dcc9ef1 into master Oct 1, 2024
66 checks passed
@Marchhill Marchhill deleted the fix/blob-fee-collector branch October 1, 2024 21:19
rjnrohit pushed a commit that referenced this pull request Oct 10, 2024
@Marchhill @rjnrohit
EIP-4844-Pectra: Blob gas fee collection for Gnosis (#6866)
2c8d589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

@flcl42 flcl42 Awaiting requested review from flcl42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marchhill @flcl42 @LukaszRozmej