Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept "latest" and "finalized" as block number values for debug_traceBlockByNumber method #4259

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Jul 8, 2022

Resolves #4133

Changes:

  • debug_traceBlockByNumber now accepts latest and finalized as a block number value
  • debug_traceBlock, debug_traceBlockByNumber, and debug_traceBlockByHash methods has been unified and refactored

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)
Test cases has been added for debug_traceBlock, debug_traceBlockByNumber, and debug_traceBlockByHash methods.

Further comments (optional)

Further refactoring, unification, and new test cases on the Debug module will be done along with the other sub-tasks of #4210.

@rubo rubo requested review from LukaszRozmej and MarekM25 July 8, 2022 19:41
@rubo rubo marked this pull request as ready for review July 10, 2022 21:18
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: I think you are using different IDE configuration changing things to var and different spaces layout, maybe lets unify?

We consider var easier to read (you don't have to guess what is there) especially when doing reviews through github, where there is no IDE to hint you.

@LukaszRozmej LukaszRozmej merged commit 5415563 into master Jul 13, 2022
@LukaszRozmej LukaszRozmej deleted the feature/debug_traceblockbynumber branch July 13, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug_traceBlockByNumber - latest and finalized - invalid params
2 participants