Accept "latest" and "finalized" as block number values for debug_traceBlockByNumber method #4259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4133
Changes:
debug_traceBlockByNumber
now acceptslatest
andfinalized
as a block number valuedebug_traceBlock
,debug_traceBlockByNumber
, anddebug_traceBlockByHash
methods has been unified and refactoredTypes of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Test cases has been added for
debug_traceBlock
,debug_traceBlockByNumber
, anddebug_traceBlockByHash
methods.Further comments (optional)
Further refactoring, unification, and new test cases on the Debug module will be done along with the other sub-tasks of #4210.