Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_traceBlockByNumber - latest and finalized - invalid params #4133

Closed
quickchase opened this issue Jun 8, 2022 · 4 comments · Fixed by #4259
Closed

debug_traceBlockByNumber - latest and finalized - invalid params #4133

quickchase opened this issue Jun 8, 2022 · 4 comments · Fixed by #4259
Assignees

Comments

@quickchase
Copy link

Describe the bug
It looks like debug_traceBlockByNumber is not accepting "latest" or "finalized" on the latest release on Ropsten post-merge.

To Reproduce
https://github.com/NethermindEth/nethermind/releases/tag/1.13.2

{"method":"debug_traceBlockByNumber","params":["latest"],"id":1,"jsonrpc":"2.0"}
{"method":"debug_traceBlockByNumber","params":["finalized"],"id":1,"jsonrpc":"2.0"}

Invalid params

Expected behavior
We should be able to debug_traceBlockByNumber against latest or finalized

@quickchase
Copy link
Author

This issue may pre-date the merge/latest release we only noticed after switching from OpenEthereum - I tested another node on mainnet and it has the same problem. Doesn't understand "latest"?

@LukaszRozmej
Copy link
Member

Yes it doesn't similar to Geth which also accepts only numbers there - hence the name.
We can add another overload if you need debug_traceBlockByParameter or something?

@quickchase
Copy link
Author

quickchase commented Jun 10, 2022

"latest" works perfectly fine in Geth (and Erigon):

curl -H 'Content-Type: application/json' http://localhost:8545 -d '{"method":"web3_clientVersion","params":[],"id":1,"jsonrpc":"2.0"}'
{"jsonrpc":"2.0","id":1,"result":"Geth/v1.10.13-stable/linux-amd64/go1.16.10"}

curl -H 'Content-Type: application/json' http://localhost:8545 -d '{"method":"debug_traceBlockByNumber","params":["latest",{"tracer":"callTracer"}],"id":1,"jsonrpc":"2.0"}'
{"jsonrpc":"2.0","id":1,"result":[{"result":{"type":"CALL","from":"0xffec0067f5a79cff07527f63d83dd5462ccf8ba4","to":"0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48"...<redacted>

@LukaszRozmej
Copy link
Member

This can be viewed as a part of #4210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants