Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: factory contract #96

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

julio4
Copy link
Contributor

@julio4 julio4 commented Oct 18, 2023

Issue(s): Close #42

Description

This PR adds an example of a minimalist factory contract. A more complete example can be introduced later on (with access control, deployment managements, ...).

Checklist

  • CI Verifier: Run cairo_programs_verifier successfully
  • Contract Tests: Added tests to cover the changes
  • Remix Link: Added a link to open the contract in Remix (Blocked for now: waiting for multiple files import)
  • Deployed Contract (Optional): If possible, include a Voyager link to a deployed contract on Goerli

@julio4 julio4 changed the title Feat/factory contract feat: factory contract Oct 18, 2023
@JorikSchellekens
Copy link
Contributor

Could do with a little more explanation on what a classhash is and where to find more info on the class / contract separation. Otherwise it looks good!

@julio4
Copy link
Contributor Author

julio4 commented Oct 19, 2023

Could do with a little more explanation on what a classhash is and where to find more info on the class / contract separation. Otherwise it looks good!

I wanted to add a whole chapter on contract deployment, but I'll write about it and we can always move it later.

@julio4 julio4 merged commit dcadbd1 into NethermindEth:main Oct 19, 2023
1 check passed
@julio4 julio4 deleted the feat/factory-contract branch October 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Factory Contract
2 participants