Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove #[external(v0)] #91

Closed
julio4 opened this issue Oct 8, 2023 · 1 comment · Fixed by #98
Closed

feat: remove #[external(v0)] #91

julio4 opened this issue Oct 8, 2023 · 1 comment · Fixed by #98

Comments

@julio4
Copy link
Member

julio4 commented Oct 8, 2023 •
edited
Loading

Replace #[external(v0)] usage with #[abi(per_item)] or #[abi(embed_v0)].

The "Contract interfaces and Traits generation" may also be updated to explain the new syntax.
@julio4 julio4 changed the title Update: replace #[external(v0)] Feat: remove #[external(v0)] Oct 8, 2023
@julio4 julio4 changed the title Feat: remove #[external(v0)] feat: remove #[external(v0)] Oct 11, 2023
julio4 added a commit to julio4/StarknetByExample that referenced this issue Oct 18, 2023
@julio4
fix: use abi(embed_v0) NethermindEth#91
51e30dc
@julio4
Copy link
Member Author

julio4 commented Oct 18, 2023

Visibility chapter need to be updated as well

julio4 added a commit to julio4/StarknetByExample that referenced this issue Oct 19, 2023
@julio4
fix(NethermindEth#91): remove external(v0) usage on impl block
b7b1c5f
@julio4 julio4 mentioned this issue Oct 19, 2023
Merged
1 task
julio4 added a commit that referenced this issue Oct 19, 2023
@julio4
feat: factory contract (#96)
dcadbd1 
* chore: small doc addition

* feat: add simple factory example

* fix: use abi(embed_v0) #91

* feat: added contract class/instance separation
julio4 added a commit to julio4/StarknetByExample that referenced this issue Oct 19, 2023
@julio4
fix(NethermindEth#91): remove external(v0) usage on impl block
c4fb7c0
julio4 added a commit that referenced this issue Oct 19, 2023
@julio4
fix(#91): remove external(v0) usage on impl block (#98)
3e4c697
@julio4 julio4 mentioned this issue Nov 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove external(v0) usage on impl blocks julio4/StarknetByExample
1 participant
@julio4