feat: handle mail field #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsanchietti
force-pushed
the
mail_notify
branch
from
2aefda8 to
1f90d31
Compare
gsanchietti
force-pushed
the
mail_notify
branch
from
1f90d31 to
6bc044a
Compare
…81) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR implements handling for the mail field when editing or adding a user, updating the LDAP attributes accordingly.
- In alter-user, the mail attribute is added or removed based on the request.
- In add-user, the mail attribute is updated if provided.
- In list-users, an extra_info flag is added to the user listing.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| imageroot/api-moduled/handlers/alter-user/post | Adds mail field handling with conditional update/removal |
| imageroot/api-moduled/handlers/add-user/post | Processes mail field from request and updates LDAP accordingly |
| imageroot/api-moduled/handlers/list-users/post | Requests extra user info in the user listing |
gsanchietti
force-pushed
the
mail_notify
branch
3 times, most recently
from
b4b7628 to
0acf5a6
Compare
DavidePrincipi
approved these changes
Mar 12, 2025
gsanchietti
force-pushed
the
mail_notify
branch
from
0acf5a6 to
8ce60b2
Compare
Preserve existing behavior: if a field is not specified, it will not be overwritten. To remove a mail address, just pass an empty string as value Note: a mail address with an aempty string is not allowed by AD
gsanchietti
force-pushed
the
mail_notify
branch
from
8ce60b2 to
39893c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NethServer/dev#7229
NOTE: tests were already failing