fix: delete mail field on edit

Preserve existing behavior: if a field is not specified, it will not
be overwritten.
To remove a mail address, just pass an empty string as value
Note: a mail address with an aempty string is not allowed by AD

Author: gsanchietti

imageroot/api-moduled/handlers/add-user/validate-input.json

@@ -56,7 +56,16 @@
         "mail": {
             "title": "Email address",
             "type": "string",
-            "format": "email"
+            "oneOf": [
+                {
+                    "type": "string",
+                    "format": "email"
+                },
+                {
+                    "type": "string",
+                    "maxLength": 0
+                }
+            ]
         }
     },
     "$defs": {}

imageroot/api-moduled/handlers/alter-user/post

@@ -65,16 +65,12 @@ if 'mail' in request:
     getdn_cmd = sambatool_cmd + ['user', 'show', user, '--attributes=dn']
     proc = subprocess.run(getdn_cmd, check=True, capture_output=True, text=True)
     dn = proc.stdout.strip()
-    ldbedit_cmd = ['podman', 'exec', '-i', 'samba-dc', 'ldbmodify', '-i', '-H', '/var/lib/samba/private/sam.ldb']
-    ldbedit_input = f'{dn}\nchangetype: modify\nreplace: mail\nmail: {mail}\n'
-    subprocess.run(ldbedit_cmd, input=ldbedit_input, stdout=sys.stderr, check=True, text=True)
-else:
-    # remove mail attribute
-    getdn_cmd = sambatool_cmd + ['user', 'show', user, '--attributes=dn']
-    proc = subprocess.run(getdn_cmd, check=True, capture_output=True, text=True)
-    dn = proc.stdout.strip()
-    ldbedit_cmd = ['podman', 'exec', '-i', 'samba-dc', 'ldbmodify', '-i', '-H', '/var/lib/samba/private/sam.ldb']
-    ldbedit_input = f'{dn}\nchangetype: modify\ndelete: mail\n'
+    if mail != '':
+        ldbedit_cmd = ['podman', 'exec', '-i', 'samba-dc', 'ldbmodify', '-i', '-H', '/var/lib/samba/private/sam.ldb']
+        ldbedit_input = f'{dn}\nchangetype: modify\nreplace: mail\nmail: {mail}\n'
+    else:
+        ldbedit_cmd = ['podman', 'exec', '-i', 'samba-dc', 'ldbmodify', '-H', '/var/lib/samba/private/sam.ldb']
+        ldbedit_input = f'{dn}\nchangetype: modify\ndelete: mail\n'
     subprocess.run(ldbedit_cmd, input=ldbedit_input, stdout=sys.stderr, check=True, text=True)
 
 json.dump({"status": "success", "message": "user_altered"}, fp=sys.stdout)

imageroot/api-moduled/handlers/alter-user/validate-input.json

@@ -56,7 +56,16 @@
         "mail": {
             "title": "Email address",
             "type": "string",
-            "format": "email"
+            "oneOf": [
+                {
+                    "type": "string",
+                    "format": "email"
+                },
+                {
+                    "type": "string",
+                    "maxLength": 0
+                }
+            ]
         }
     },
     "$defs": {}