Move mantis-rxcontrol from its own repo to submodule of mantis oss #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis setup
Fix travis badge link.
Clutch will now always scale on a UserDefined metric if one is present in the metrics stream. It will also now pin high for the first config so as to prevent underscaling while it is learning about the environment. Also added some additional unit tests for the control loop. Finally added license headers.
Reduced gain by approximately two orders of magnitude but set proportional to the RPS computed by the instance. There are significant wins to be had scheduling a more approporiate gain but some thought will need to go into this process.
…operly unsubscribe.
…ics as the scaler sees them.
Fix bug on getting dominant resource with exception java.lang.IllegalStateException: stream has already been operated upon or closed
Fix bug worker count reset to initial size every day
Introduce integral decay factor in PIDController
Fix bug where current number of worker is incorrect
Updating publish and snapshot workflows
Update netflixoss plugin version
Add descriptive stats as a test
Fix snapshot pr target
…bmodule of mantis OSS
hmitnflx
requested review from
calvin681,
sundargates,
Andyz26 and
fdc-ntflx
as code owners
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
approved these changes
Apr 30, 2024
sundargates
reviewed
Apr 30, 2024
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.netflix.control.clutch; |
There was a problem hiding this comment.
Changing the package name should be fine!
There was a problem hiding this comment.
Yep, good idea, done!
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Explain context and other details for this pull request.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests