Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compile vs api. #3

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Use compile vs api. #3

merged 1 commit into from
Jul 8, 2019

Conversation

jeffchao
Copy link
Contributor

@jeffchao jeffchao commented Jul 8, 2019

Context

The api feature isn't compatible with this version of fatJar. This
causes problems when mantis workers try to load the
io.mantisrx.server.worker.MantisWorker class since it extends
BaseService which won't exist in the fatJar without compile.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
  • Added copyright headers for new files from CONTRIBUTING.md

The `api` feature isn't compatible with this version of fatJar. This
causes problems when mantis workers try to load the
`io.mantisrx.server.worker.MantisWorker` class since it extends
`BaseService` which won't exist in the fatJar without `compile`.
@jeffchao jeffchao self-assigned this Jul 8, 2019
@jeffchao jeffchao merged commit 4810511 into master Jul 8, 2019
@jeffchao jeffchao deleted the dependencies-fatjar branch July 8, 2019 16:57
nickmahilani pushed a commit to nickmahilani/mantis that referenced this pull request Sep 21, 2019
jeffchao added a commit that referenced this pull request Sep 30, 2020
jeffchao added a commit that referenced this pull request Oct 2, 2020
Don't run flaky tests.
jeffchao added a commit that referenced this pull request Oct 2, 2020
jeffchao added a commit that referenced this pull request Oct 2, 2020
hmitnflx pushed a commit that referenced this pull request Apr 30, 2024
Fix bug on getting dominant resource with exception java.lang.IllegalStateException: stream has already been operated upon or closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant