Use compile vs api.
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `api` feature isn't compatible with this version of fatJar. This causes problems when mantis workers try to load the `io.mantisrx.server.worker.MantisWorker` class since it extends `BaseService` which won't exist in the fatJar without `compile`.
jeffchao
requested review from
codyrioux,
neerajrj,
nickmahilani,
skalidindi and
zhenzhongxu
as code owners
nickmahilani
pushed a commit
to nickmahilani/mantis
that referenced
this pull request
Sep 21, 2019
Use `compile` vs `api`.
5 tasks
hmitnflx
pushed a commit
that referenced
this pull request
Apr 30, 2024
Fix bug on getting dominant resource with exception java.lang.IllegalStateException: stream has already been operated upon or closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
apifeature isn't compatible with this version of fatJar. Thiscauses problems when mantis workers try to load the
io.mantisrx.server.worker.MantisWorkerclass since it extendsBaseServicewhich won't exist in the fatJar withoutcompile.Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all testsCONTRIBUTING.md