-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated gems, Added No SSL, Add Error handling #49
Conversation
Gem winrm 2.x; option to specify WinRM transport protocol
no ssl verification
Merge community improvements into repo
Community improvements
Community improvements
I removed the attempted quote problem fix from lines 32 to 38 as I found it made no difference in my testing. Rundeck have documented the problem and solution in their documentation so I feel that is adequate until they fix the bug internally: http://rundeck.org/docs/manual/jobs.html#quoting-arguments-to-steps Happy for other POV's/input on this choice. |
This looks like a pretty big change. Should this be 1.7.0 and not 1.6.2 ? |
Update Version
Update Version
Yes it should be, seems I missed the CHANGELOG. |
Does this work? We aren't actively using rundeck at the moment so we can't test this. If you are confident, I'll accept this. |
It does, I'm currently running it in Production against ~9000 servers. |
Hi guys, I tested this and it worked OK. Luis |
Hi guys,
I pulled in the changes Stoned and Rodolfo made in my personal branch, then built on top of those some improvements I've been wanting around the error handling.
You'll now only get the full Ruby stack trace if the job is ran in DEBUG mode.
Otherwise you'll get a simple message in NORMAL mode, this makes the plugin much friendlier for non dev's reading the job outputs and for parsing in other systems.
Any other requests/recommendations?
I'm using this updated code on both my Test and Production systems at the moment with no issue.