Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gems, Added No SSL, Add Error handling #49

Merged
merged 23 commits into from
Oct 26, 2017
Merged

Updated gems, Added No SSL, Add Error handling #49

merged 23 commits into from
Oct 26, 2017

Conversation

UnicodeTreason
Copy link
Contributor

Hi guys,

I pulled in the changes Stoned and Rodolfo made in my personal branch, then built on top of those some improvements I've been wanting around the error handling.

You'll now only get the full Ruby stack trace if the job is ran in DEBUG mode.
Otherwise you'll get a simple message in NORMAL mode, this makes the plugin much friendlier for non dev's reading the job outputs and for parsing in other systems.

Any other requests/recommendations?
I'm using this updated code on both my Test and Production systems at the moment with no issue.

@UnicodeTreason
Copy link
Contributor Author

I removed the attempted quote problem fix from lines 32 to 38 as I found it made no difference in my testing.

Rundeck have documented the problem and solution in their documentation so I feel that is adequate until they fix the bug internally: http://rundeck.org/docs/manual/jobs.html#quoting-arguments-to-steps

Happy for other POV's/input on this choice.

@spuder
Copy link
Contributor

spuder commented Oct 20, 2017

This looks like a pretty big change. Should this be 1.7.0 and not 1.6.2 ?

Justin Riedyk added 2 commits October 21, 2017 07:13
Update Version
Update Version
@UnicodeTreason
Copy link
Contributor Author

Yes it should be, seems I missed the CHANGELOG.
Any other changes required?
Would you like me to update to releases with v1.7.0?
I already have the .zip ready

@spuder
Copy link
Contributor

spuder commented Oct 25, 2017

Does this work? We aren't actively using rundeck at the moment so we can't test this. If you are confident, I'll accept this.

@UnicodeTreason
Copy link
Contributor Author

It does, I'm currently running it in Production against ~9000 servers.

@ltamaster
Copy link

Hi guys,

I tested this and it worked OK.

Luis

@spuder spuder merged commit f0957ee into NetDocuments-Archive:master Oct 26, 2017
This was referenced Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants