Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request : update winrm and winrm-fs #43

Closed
FireHelmet opened this issue Apr 4, 2017 · 13 comments
Closed

Request : update winrm and winrm-fs #43

FireHelmet opened this issue Apr 4, 2017 · 13 comments

Comments

@FireHelmet
Copy link

FireHelmet commented Apr 4, 2017

Hello,

Could you update your plugin to use the last updates of winrm and winrm-fs ?

Winrm : 2.2.1
Winrm-fs : 1.0.1

Thank to you for your great plugin.

@FireHelmet
Copy link
Author

Hello,

Some news about that ?

:)

@spuder
Copy link
Contributor

spuder commented Apr 24, 2017

We aren't actively using the plugin at the moment, so we don't have a way to test this. Pull requests welcome.

@FireHelmet
Copy link
Author

Hello spuder,

Thank for your answer. I'm using this fork https://github.com/stoned/rd-winrm-plugin/tree/gem-winrm-2 of your project from 1 month without problem in production. Maybe you can merge your code :) and this topic will be solved.

Thanks !

@vvchik
Copy link
Contributor

vvchik commented Apr 25, 2017

I've reviewed your code, quickly. On the first impression, it looks good. Please create PR. :)

@FireHelmet
Copy link
Author

It's not my code, it's from Stoned (user). I'm not a power user of Github, but I think my PR it's well done:
#45

Thanks !

@vvchik
Copy link
Contributor

vvchik commented Apr 25, 2017

Oh, It is my mistake I didn't realize that code from another user.
I not so powerful in licensing, but I think we need to have @stoned approval, before merging it.

@stoned
Copy link
Contributor

stoned commented Apr 25, 2017

Hi,
There is no problem on my side. You could proceed with the PR. Thank you for your time !

@FireHelmet
Copy link
Author

@stoned Thank to you.

@FireHelmet
Copy link
Author

@vvchik ,

Could you merge the PR ?

Thanks

@DerfOh
Copy link

DerfOh commented Aug 2, 2017

@vvchik ping!
I would like to see this merged too. Thanks for all your hard work @stoned and everyone else 😃

@spuder
Copy link
Contributor

spuder commented Aug 2, 2017

Before that can be merged, the version number needs to be fixed. 1.6.0.1 isn't the right version number, it needs to be 1.7.0

@FireHelmet
Copy link
Author

@stoned Could you update the version like asked by @spuder ?

Thank you for your work !

@UnicodeTreason
Copy link
Contributor

This has been resolved by #50 and #49 so can be closed.

@spuder spuder closed this as completed Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants