Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe ops for QQ/ZZPolyRingElem, QQ/ZZMatrix #1907

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

fingolfin
Copy link
Member

Move flintify calls down into unsafe ops

@fingolfin
Copy link
Member Author

Ah it seems this may require PR #1905. Let's try again once that one is merged.

@fingolfin fingolfin closed this Oct 17, 2024
@fingolfin fingolfin reopened this Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 82.54545% with 48 lines in your changes missing coverage. Please review.

Project coverage is 87.21%. Comparing base (6848ca3) to head (81b8471).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/fmpz_poly.jl 73.52% 18 Missing ⚠️
src/flint/fmpq_poly.jl 84.78% 14 Missing ⚠️
src/flint/fmpz_mat.jl 70.45% 13 Missing ⚠️
src/flint/fmpq_mat.jl 96.55% 2 Missing ⚠️
src/flint/FlintTypes.jl 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
- Coverage   87.24%   87.21%   -0.03%     
==========================================
  Files          97       97              
  Lines       35636    35588      -48     
==========================================
- Hits        31089    31038      -51     
- Misses       4547     4550       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin fingolfin force-pushed the mh/unsafe-op-fmpqz_mat-_poly branch 2 times, most recently from a80d3c7 to d7405fb Compare October 17, 2024 21:08
src/flint/fmpq_mat.jl Outdated Show resolved Hide resolved
src/flint/fmpz_mat.jl Outdated Show resolved Hide resolved
src/flint/fmpz_mat.jl Outdated Show resolved Hide resolved
src/flint/fmpz_mat.jl Outdated Show resolved Hide resolved
Move flintify calls down into unsafe ops
@fingolfin fingolfin enabled auto-merge (squash) October 18, 2024 10:39
@fingolfin fingolfin merged commit 0c2c84d into master Oct 18, 2024
24 of 25 checks passed
@fingolfin fingolfin deleted the mh/unsafe-op-fmpqz_mat-_poly branch October 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants