Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe ops for ZZRingElem, QQFieldElem #1905

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Unsafe ops for ZZRingElem, QQFieldElem #1905

merged 2 commits into from
Oct 17, 2024

Conversation

fingolfin
Copy link
Member

Move flintify calls down into unsafe ops

Also reorder method defs to add,sub,mul

Move flintify calls down into unsafe ops

Also reorder method defs to add,sub,mul
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 12 lines in your changes missing coverage. Please review.

Project coverage is 87.24%. Comparing base (1e48bb0) to head (9a55fbf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/fmpz.jl 56.25% 7 Missing ⚠️
src/flint/fmpq.jl 82.14% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1905      +/-   ##
==========================================
- Coverage   87.25%   87.24%   -0.02%     
==========================================
  Files          97       97              
  Lines       35651    35651              
==========================================
- Hits        31109    31103       -6     
- Misses       4542     4548       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/flint/fmpq.jl Outdated Show resolved Hide resolved
@fingolfin fingolfin merged commit 50132ae into master Oct 17, 2024
46 of 48 checks passed
@fingolfin fingolfin deleted the mh/unsafe-op-fmpqz branch October 17, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants