-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging fixes. #4693
Staging fixes. #4693
Conversation
MistakeNot4892
commented
Jan 4, 2025
•
edited
Loading
edited
- Fixes The oven considers itself full after roasing coffee ScavStation/ScavStation#1169.
- Mitigates Mobs with water in the reagents holder cause slippery floors and do not appear to run out of contact reagents. ScavStation/ScavStation#1164.
- Fixes being wet causes ink on paper to wash off ScavStation/ScavStation#1162.
- Fixes Mortars don't take items to grind ScavStation/ScavStation#1161.
- Fixes AI UI buttons do not work ScavStation/ScavStation#1172.
- Fixes cannot put baton back into loaded (With gun) holster ScavStation/ScavStation#1163.
- Dripping is now faster.
- fluid_act() is now applied to mobs only after meeting certain thresholds.
- Paint is not applied except when the volume exceeds item size for movables and a minimum fluid threshold for turfs.
- Floor slipperiness is only applied after meeting a minimum fluid threshold.
- Dirt will no longer visibly fall through open turfs.
- Adds level data list validation to /datum/map and tweaks maps to pass the checks.
- Removes testing maps from map votes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there seem to be a lot of confusing and poorly atomized changes in this PR, but it's a fix pr so i don't mind too much. i do have a few nitpicks though
Sorry about the non-atomic changes, this was a bit of a stream of consciousness PR. Thought I had them mostly broken up, alas. |
2061ff4
to
26153a2
Compare
26153a2
to
e55d256
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really poorly atomized. welp! good enough for me.
also someone needs to fix the nanoui map generation to only take into account the level data bounds or whatever. i'll probably do it later