Skip to content

Commit

Permalink
Merge pull request #4697 from out-of-phaze/fix/missing-shaded-tweaks
Browse files Browse the repository at this point in the history
Apply missing Shaded Hills fixes
  • Loading branch information
MistakeNot4892 authored Jan 6, 2025
2 parents 48d91e1 + a3acdd5 commit 29d180f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 6 deletions.
3 changes: 3 additions & 0 deletions code/modules/crafting/handmade_items.dm
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
if((. = ..()))
update_icon()

/obj/item/chems/glass/handmade/get_mould_difficulty()
return SKILL_NONE

/obj/item/chems/glass/handmade/teapot
name = "teapot"
desc = "A handmade, slightly lumpy teapot."
Expand Down
13 changes: 7 additions & 6 deletions code/modules/detectivework/evidence/_evidence_type.dm
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,18 @@
var/max_entries = 10 //will hold that many entries, removing oldest when overflown
var/list/data
var/remove_on_transfer //if it should be removed when picked up by forensic samplers
var/spot_skill = SKILL_EXPERT // at what Forensics skill level someone can see it on examine. Set to null, can never see it
var/spot_skill = SKILL_EXPERT // at what Forensics skill level someone can see it on examine. Set to null, can never see it

//subtypes can implement any merging if needed before calling parent
/datum/forensics/proc/add_data(newdata)
if(!newdata)
return
if(unique && (newdata in data))
return
LAZYADD(data, newdata)
if(unique)
LAZYDISTINCTADD(data, newdata)
else
LAZYADD(data, newdata)
if(length(data) > max_entries)
data.Cut(1,2)
data.len = max_entries

/datum/forensics/proc/add_from_atom(atom/A)

Expand All @@ -28,7 +29,7 @@
for(var/D in data)
. += "<li>[D]"
return jointext(., "<br>")

/datum/forensics/proc/can_spot(mob/detective, atom/location)
. = FALSE
if(spot_skill && detective.skill_check(SKILL_FORENSICS,spot_skill))
Expand Down
1 change: 1 addition & 0 deletions code/modules/detectivework/evidence/fingerprints.dm
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
continue
for(var/datum/fingerprint/F in data)
if(F.merge(newprint))
newdata -= newprint
continue
..()

Expand Down

0 comments on commit 29d180f

Please sign in to comment.