Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default contact sensors #206

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

sibocw
Copy link
Contributor

@sibocw sibocw commented Jul 23, 2024

Description

We have a lot of code that has something like this:

contact_sensor_placements = [
    f"{leg}{segment}"
    for leg in ["LF", "LM", "LH", "RF", "RM", "RH"]
    for segment in ["Tibia", "Tarsus1", "Tarsus2", "Tarsus3", "Tarsus4", "Tarsus5"]
]

fly = HybridTurningFly(
    contact_sensor_placements=contact_sensor_placements,
    ...
)

It's nice to add this hardcoded contact_sensor_placements as flygym.preprogrammed.default_leg_sensor_placements.

Does this address any currently open issues?

No

@sibocw sibocw marked this pull request as ready for review July 23, 2024 12:03
@sibocw sibocw merged commit 76dd7cf into dev-v1.0.1-pre.1 Jul 23, 2024
13 checks passed
@sibocw sibocw deleted the add-default-contact-sensors branch July 23, 2024 12:04
@sibocw
Copy link
Contributor Author

sibocw commented Jul 23, 2024

Note: A test failed specifically on MacOS 13. This test tries to fit a path integration model on only 1 second of simulated data and asserts that we have a r2 score of at least 0.5. I don't know why it started failing here but made the simulation 2 seconds to make the r2 a bit more reliable (76dc981).

@sibocw sibocw mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant