Fix very low playspeed rendering #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d playspeed is so low that there every single step of simulation is rendered
|
@stimpfli: Please be aware of this in the new Camera API. |
Merged
stimpfli
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: If the specified video playspeed is so low (or if video FPS is so high, or a combination thereof) that the frequency of rendering is higher than the frequency of the physics simulation (the former is effectively bound to the latter, of course),
Camera.save_videodoesn't work correctly with non-zerostabilization_time. It over-counts the number of frames during the stabilization period and therefore are to be dropped.This PR fixes this bug.
Does this address any currently open issues?
No