Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out #pragma message WARN lines #913

Merged
merged 1 commit into from
Sep 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Engine/AppManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3844,7 +3844,7 @@ NATRON_PYTHON_NAMESPACE::isKeyword(const std::string& str)
}

#if !defined(NDEBUG) && !defined(DEBUG_PYTHON_GIL)
#pragma message WARN("define DEBUG_PYTHON_GIL in AppManager.h to debug Python GIL issues")
//#pragma message WARN("define DEBUG_PYTHON_GIL in AppManager.h to debug Python GIL issues")
#endif

#ifdef DEBUG_PYTHON_GIL
Expand Down
2 changes: 1 addition & 1 deletion Engine/EffectInstance.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3874,7 +3874,7 @@ EffectInstance::getRegionOfDefinition_public(U64 hash,
if (isProjectFormat) {
*isProjectFormat = false;
}
#pragma message WARN("[FD] why is an empty RoD a failure case? this is ignored in renderRoI, search for 'if getRoD fails, this might be because the RoD is null after all (e.g: an empty Roto node), we don't want the render to fail'")
//#pragma message WARN("[FD] why is an empty RoD a failure case? this is ignored in renderRoI, search for 'if getRoD fails, this might be because the RoD is null after all (e.g: an empty Roto node), we don't want the render to fail'")
if ( rod->isNull() ) {
return eStatusFailed;
}
Expand Down
2 changes: 1 addition & 1 deletion Engine/Knob.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ struct KnobHelperPrivate
KnobHelper* publicInterface;

#ifdef DEBUG
#pragma message WARN("This should be a weak_ptr")
//#pragma message WARN("This should be a weak_ptr")
#endif
KnobHolder* holder;
mutable QMutex labelMutex;
Expand Down
2 changes: 1 addition & 1 deletion Engine/KnobTypes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ bool BothAreSpaces(char lhs, char rhs) { return (lhs == rhs) && (lhs == ' '); }
// 5- paren/bracket-insensitive match (for WriteFFmpeg's format and codecs)
// 6- if the choice ends with " 1" try to match exactly everything before that (for formats with PAR=1, where the PAR was removed)
// returns index if choice was matched, -1 if not matched
#pragma message WARN("choiceMatch() should be moved into filterKnobChoiceOptionCompat().")
//#pragma message WARN("choiceMatch() should be moved into filterKnobChoiceOptionCompat().")
// TODO: choiceMatch() should be moved into filterKnobChoiceOptionCompat()
// TODO: filterKnobChoiceOptionCompat() should be used everywhere instead of choiceMatch()
int
Expand Down
2 changes: 1 addition & 1 deletion Engine/NodeMain.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ Node::Implementation::restoreUserKnobsRecursive(const std::list<KnobSerializatio
std::string optionID = choiceData->_choiceString;
// first, try to get the id the easy way ( see choiceMatch() )
int id = isChoice->choiceRestorationId(choiceSerialized, optionID);
#pragma message WARN("TODO: choice id filters")
//#pragma message WARN("TODO: choice id filters")
//if (id < 0) {
// // no luck, try the filters
// filterKnobChoiceOptionCompat(getPluginID(), serialization.getPluginMajorVersion(), serialization.getPluginMinorVersion(), projectInfos.vMajor, projectInfos.vMinor, projectInfos.vRev, serializedName, &optionID);
Expand Down
4 changes: 2 additions & 2 deletions Engine/OfxEffectInstance.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ OfxEffectInstance::tryInitializeOverlayInteracts()
OFX::Host::Interact::Descriptor &interactDesc = paramToKnob->getInteractDesc();
interactDesc.getProperties().addProperties(interactDescProps);
interactDesc.setEntryPoint(interactEntryPoint);
#pragma message WARN("FIXME: bitdepth and hasalpha are probably wrong")
//#pragma message WARN("FIXME: bitdepth and hasalpha are probably wrong")
interactDesc.describe(/*bitdepthPerComponent=*/ 8, /*hasAlpha=*/ false);
OfxParamOverlayInteractPtr overlayInteract( new OfxParamOverlayInteract( knob.get(), interactDesc, effectInstance()->getHandle()) );
knob->setCustomInteract(overlayInteract);
Expand Down Expand Up @@ -1863,7 +1863,7 @@ OfxEffectInstance::isIdentity(double time,
stat = _imp->effect->isIdentityAction(inputTimeOfx, field, ofxRoI, scale, identityView, identityPlane, inputclip);
}
if (identityView != view || identityPlane != kFnOfxImagePlaneColour) {
#pragma message WARN("can Natron RB2-multiplane2 handle isIdentity across views and planes?")
//#pragma message WARN("can Natron RB2-multiplane2 handle isIdentity across views and planes?")
// Natron 2 cannot handle isIdentity across planes
stat = kOfxStatOK;
}
Expand Down
2 changes: 1 addition & 1 deletion Engine/OfxParamInstance.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4831,7 +4831,7 @@ OfxParametricInstance::addControlPoint(int curveIndex,
KeyframeTypeEnum interpolation = eKeyframeTypeSmooth; // a reasonable default
// The initial curve for some plugins may be better with a specific interpolation. Unfortunately, the kOfxParametricSuiteV1 doesn't offer different interpolation methods
#ifdef DEBUG
#pragma message WARN("This is a hack, we should extend the parametric suite to add derivatives infos")
//#pragma message WARN("This is a hack, we should extend the parametric suite to add derivatives infos")
#endif
if (effect) {
if ( (effect->getPluginID() == PLUGINID_OFX_COLORCORRECT) || (effect->getPluginID() == PLUGINID_OFX_TIMEDISSOLVE) ) {
Expand Down
2 changes: 1 addition & 1 deletion Engine/ParallelRenderArgs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ EffectInstance::getInputsRoIsFunctor(bool useTransforms,
///Concatenate transforms if needed
if (useTransforms) {
fvRequest->globalData.transforms = std::make_shared<InputMatrixMap>();
#pragma message WARN("TODO: can set draftRender properly here?")
//#pragma message WARN("TODO: can set draftRender properly here?")
effect->tryConcatenateTransforms( time, /*draftRender=*/false, view, nodeRequest->mappedScale, fvRequest->globalData.transforms.get() );
}

Expand Down
2 changes: 1 addition & 1 deletion Engine/Project.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1190,7 +1190,7 @@ Project::getProjectDefaultFormat(Format *f) const
ChoiceOption formatSpec = _imp->formatKnob->getActiveEntry();
// use the label here, because the id does not contain the format specifications.
// see ProjectPrivate::generateStringFromFormat()
#pragma message WARN("TODO: can't we store the format somewhere instead of parsing the label???")
//#pragma message WARN("TODO: can't we store the format somewhere instead of parsing the label???")
if ( !formatSpec.label.empty() ) {
ProjectPrivate::generateFormatFromString(QString::fromUtf8( formatSpec.label.c_str() ), f);
} else {
Expand Down
2 changes: 1 addition & 1 deletion Engine/ProjectPrivate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ ProjectPrivate::restoreFromSerialization(const ProjectSerialization & obj,
std::string optionID = choiceData->_choiceString;
// first, try to get the id the easy way ( see choiceMatch() )
int id = isChoice->choiceRestorationId(choiceSerialized, optionID);
#pragma message WARN("TODO: choice id filters")
//#pragma message WARN("TODO: choice id filters")
//if (id < 0) {
// // no luck, try the filters
// filterKnobChoiceOptionCompat(getPluginID(), serialization.getPluginMajorVersion(), serialization.getPluginMinorVersion(), projectInfos.vMajor, projectInfos.vMinor, projectInfos.vRev, serializedName, &optionID);
Expand Down
6 changes: 3 additions & 3 deletions Engine/ReadNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ ReadNodePrivate::cloneGenericKnobs()
std::string optionID = choiceData->_choiceString;
// first, try to get the id the easy way ( see choiceMatch() )
int id = isChoice->choiceRestorationId(choiceSerialized, optionID);
#pragma message WARN("TODO: choice id filters")
//#pragma message WARN("TODO: choice id filters")
//if (id < 0) {
// // no luck, try the filters
// filterKnobChoiceOptionCompat(getPluginID(), serialization.getPluginMajorVersion(), serialization.getPluginMinorVersion(), projectInfos.vMajor, projectInfos.vMinor, projectInfos.vRev, serializedName, &optionID);
Expand Down Expand Up @@ -552,7 +552,7 @@ ReadNodePrivate::destroyReadNode()

//This will remove the GUI of non generic parameters
_publicInterface->recreateKnobs(true);
#pragma message WARN("TODO: if Gui, refresh pluginID, version, help tooltip in DockablePanel to reflect embedded node change")
//#pragma message WARN("TODO: if Gui, refresh pluginID, version, help tooltip in DockablePanel to reflect embedded node change")

QMutexLocker k(&embeddedPluginMutex);
if (embeddedPlugin) {
Expand Down Expand Up @@ -793,7 +793,7 @@ ReadNodePrivate::createReadNode(bool throwErrors,

//This will refresh the GUI with this Reader specific parameters
_publicInterface->recreateKnobs(true);
#pragma message WARN("TODO: if Gui, refresh pluginID, version, help tooltip in DockablePanel to reflect embedded node change")
//#pragma message WARN("TODO: if Gui, refresh pluginID, version, help tooltip in DockablePanel to reflect embedded node change")

KnobIPtr knob = node ? node->getKnobByName(kOfxImageEffectFileParamName) : _publicInterface->getKnobByName(kOfxImageEffectFileParamName);
if (knob) {
Expand Down
6 changes: 3 additions & 3 deletions Engine/RotoContextPrivate.h
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ struct RotoDrawableItemPrivate
int defVal = 0;
{
std::vector<ChoiceOption> choices;
#pragma message WARN("TODO: better sync with OFX filter param")
//#pragma message WARN("TODO: better sync with OFX filter param")
// must be kept in sync with ofxsFilter.h
choices.push_back(ChoiceOption("impulse", kFilterImpulse, tr(kFilterImpulseHint).toStdString()));
choices.push_back(ChoiceOption("box", kFilterBox, tr(kFilterBoxHint).toStdString()));
Expand Down Expand Up @@ -2081,7 +2081,7 @@ struct RotoContextPrivate
shutterType->setDefaultValue(0);
{
std::vector<ChoiceOption> options;
#pragma message WARN("TODO: sync with ofxsShutter")
//#pragma message WARN("TODO: sync with ofxsShutter")
options.push_back(ChoiceOption("centered", "Centered", tr(kRotoShutterOffsetCenteredHint).toStdString()));
options.push_back(ChoiceOption("start", "Start", tr(kRotoShutterOffsetStartHint).toStdString()));
options.push_back(ChoiceOption("end", "End", tr(kRotoShutterOffsetEndHint).toStdString()));
Expand Down Expand Up @@ -2139,7 +2139,7 @@ struct RotoContextPrivate
globalShutterType->setHintToolTip( tr(kRotoShutterOffsetTypeParamHint) );
globalShutterType->setDefaultValue(0);
{
#pragma message WARN("TODO: sync with ofxsShutter")
//#pragma message WARN("TODO: sync with ofxsShutter")
std::vector<std::string> options, helps;
options.push_back("Centered");
helps.push_back(kRotoShutterOffsetCenteredHint);
Expand Down
2 changes: 1 addition & 1 deletion Engine/TrackerFrameAccessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ TrackerFrameAccessor::GetMaskForTrack(int clip,
// https://developer.blender.org/rBb0015686e2e48a384a0b2a03a75f6daaad7271c0
//

#pragma message WARN("TODO: implement TrackerFrameAccessor::GetMaskForTrack")
//#pragma message WARN("TODO: implement TrackerFrameAccessor::GetMaskForTrack")

return NULL;
}
Expand Down
4 changes: 2 additions & 2 deletions Engine/ViewerInstance.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,7 @@ ViewerInstance::getRegionsOfInterest(double /*time*/,
ViewIdx /*view*/,
RoIMap* ret)
{
#pragma message WARN("2.2: fix this and only add RoI for thread local input")
//#pragma message WARN("2.2: fix this and only add RoI for thread local input")
for (int i = 0; i < getNInputs(); ++i) {
EffectInstancePtr input = getInput(i);
if (input) {
Expand Down Expand Up @@ -1503,7 +1503,7 @@ ViewerInstance::renderViewer_internal(ViewIdx view,
stats->setGlobalRenderInfosForNode(getNode(), inArgs.params->rod, inArgs.params->srcPremult, channelsRendered, true, true, inArgs.params->mipMapLevel);
}

#pragma message WARN("Implement Viewer so it accepts OpenGL Textures in input")
//#pragma message WARN("Implement Viewer so it accepts OpenGL Textures in input")
BufferableObjectPtrList partialUpdateObjects;
for (std::size_t rectIndex = 0; rectIndex < splitRoi.size(); ++rectIndex) {
//AlphaImage will only be set when displaying the Matte overlay
Expand Down
6 changes: 3 additions & 3 deletions Engine/WriteNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ WriteNodePrivate::cloneGenericKnobs()
std::string optionID = choiceData->_choiceString;
// first, try to get the id the easy way ( see choiceMatch() )
int id = isChoice->choiceRestorationId(choiceSerialized, optionID);
#pragma message WARN("TODO: choice id filters")
//#pragma message WARN("TODO: choice id filters")
//if (id < 0) {
// // no luck, try the filters
// filterKnobChoiceOptionCompat(getPluginID(), serialization.getPluginMajorVersion(), serialization.getPluginMinorVersion(), projectInfos.vMajor, projectInfos.vMinor, projectInfos.vRev, serializedName, &optionID);
Expand Down Expand Up @@ -513,7 +513,7 @@ WriteNodePrivate::destroyWriteNode()

//This will remove the GUI of non generic parameters
_publicInterface->recreateKnobs(true);
#pragma message WARN("TODO: if Gui, refresh pluginID, version, help tooltip in DockablePanel to reflect embedded node change")
//#pragma message WARN("TODO: if Gui, refresh pluginID, version, help tooltip in DockablePanel to reflect embedded node change")

if (embeddedNode) {
embeddedNode->destroyNode(true, false);
Expand Down Expand Up @@ -878,7 +878,7 @@ WriteNodePrivate::createWriteNode(bool throwErrors,

//This will refresh the GUI with this Reader specific parameters
_publicInterface->recreateKnobs(true);
#pragma message WARN("TODO: if Gui, refresh pluginID, version, help tooltip in DockablePanel to reflect embedded node change")
//#pragma message WARN("TODO: if Gui, refresh pluginID, version, help tooltip in DockablePanel to reflect embedded node change")

KnobIPtr knob = writeNode ? writeNode->getKnobByName(kOfxImageEffectFileParamName) : _publicInterface->getKnobByName(kOfxImageEffectFileParamName);
if (knob) {
Expand Down
2 changes: 1 addition & 1 deletion Gui/DocumentationManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ DocumentationManager::handler(QHttpRequest *req,
html = parser(html, docDir);
body = html.toUtf8();
} else if ( page == QString::fromUtf8("_group.html") ) {
#pragma message WARN("TODO: produce HTML from file templates")
//#pragma message WARN("TODO: produce HTML from file templates")
// TODO: we should really read and parse _group.html or _groupChannel.html and just replace the relevant sections
QString html;
QString group;
Expand Down
2 changes: 1 addition & 1 deletion Gui/DopeSheetView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1984,7 +1984,7 @@ DopeSheetViewPrivate::computeRetimeRange(DSNode *retimer)

FrameRange range;
#ifdef DEBUG
#pragma message WARN("only considering first view")
//#pragma message WARN("only considering first view")
#endif
{
const FrameRangesMap& rangeFirst = framesFirst[0];
Expand Down
2 changes: 1 addition & 1 deletion Gui/Histogram.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ HistogramPrivate::computeHistogram(Histogram::DisplayModeEnum channel)
GLenum attachment = colorAttachmentFromDisplayMode(channel);

#ifdef DEBUG
#pragma message WARN("TODO: ave currently bound VA, Buffer, and bound texture")
//#pragma message WARN("TODO: ave currently bound VA, Buffer, and bound texture")
#endif
/*binding the VAO holding managing the VBO*/
glBindVertexArray(vaoID);
Expand Down
2 changes: 1 addition & 1 deletion Gui/NodeGraph10.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ NodeGraph::mousePressEvent(QMouseEvent* e)

if ( ( (nearbyItemCode == eNearbyItemNode) || (nearbyItemCode == eNearbyItemBackdropFrame) ) && groupEdited ) {
assert(nearbyNode);
#pragma message WARN("TODO: if control is held, select all the nodes above, see https://github.com/NatronGitHub/Natron/issues/97")
//#pragma message WARN("TODO: if control is held, select all the nodes above, see https://github.com/NatronGitHub/Natron/issues/97")
NodeGuiPtr selectedNode = nearbyNode->shared_from_this();

didSomething = true;
Expand Down
2 changes: 1 addition & 1 deletion Gui/ViewerGL.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3794,7 +3794,7 @@ ViewerGL::pickColorInternal(double x,
bool /*pickInput*/)
{

#pragma message WARN("Todo: use pickInput")
//#pragma message WARN("Todo: use pickInput")
float r, g, b, a;
QPointF imgPos;
{
Expand Down