Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out #pragma message WARN lines #913

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

acolwell
Copy link
Collaborator

@acolwell acolwell commented Sep 4, 2023

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Commenting out #pragma lines since they make it harder to see actual errors in the compiler output. These warnings don't actually seem useful and don't appear to be high priority issues that need to be addressed.

Have you tested your changes (if applicable)? If so, how?

Yes. Code builds fine with the lines commented out and the compiler output looks much cleaner.

Commenting out #pragma lines since they make it harder to see actual
errors in the compiler output. These warnings don't actually seem
useful and don't appear to be high priority issues that need to be
addressed.
@acolwell acolwell requested a review from devernay September 5, 2023 00:56
Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolwell acolwell merged commit ae9f0ba into NatronGitHub:RB-2.5 Sep 5, 2023
@acolwell acolwell deleted the comment_out_pragma_message branch September 5, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants