Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport branch/2.3.x] Fix C++11 support of recently added tests #658

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2023

Description

Backport of #651 to branch/2.3.x.

@github-actions github-actions bot requested review from a team as code owners November 3, 2023 19:37
Copy link

copy-pr-bot bot commented Nov 3, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jrhemstad
Copy link
Collaborator

/ok to test

Copy link
Collaborator

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merging this until we figure out how we want to merge backport PRs.

ahendriksen and others added 3 commits November 8, 2023 08:51
The tests themselves use C++14 constexpr features. The library code is
still tested through:

PASS: libcu++ :: cuda/barrier/cp_async_bulk_ptx_compiles.pass.cpp (6 of 9)
PASS: libcu++ :: cuda/barrier/cp_async_bulk_feature_test.pass.cpp (7 of 9)
PASS: libcu++ :: cuda/barrier/cp_async_bulk.pass.cpp (8 of 9)
PASS: libcu++ :: cuda/barrier/cp_async_bulk_tensor.pass.cpp (9 of 9)
(cherry picked from commit cbbe848)
(cherry picked from commit 5c112d2)
@jrhemstad
Copy link
Collaborator

/ok to test

@jrhemstad jrhemstad merged commit c9de0e8 into branch/2.3.x Nov 8, 2023
516 checks passed
@miscco miscco deleted the backport-651-to-branch/2.3.x branch March 7, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants