Fix C++11 support of recently added tests #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests themselves use C++14 constexpr features. The library code is still tested through: PASS: libcu++ :: cuda/barrier/cp_async_bulk_ptx_compiles.pass.cpp (6 of 9) PASS: libcu++ :: cuda/barrier/cp_async_bulk_feature_test.pass.cpp (7 of 9) PASS: libcu++ :: cuda/barrier/cp_async_bulk.pass.cpp (8 of 9) PASS: libcu++ :: cuda/barrier/cp_async_bulk_tensor.pass.cpp (9 of 9)
ahendriksen
requested review from
miscco and
wmaxey
and removed request for
a team
jrhemstad
added
the
backport branch/2.3.x
miscco
approved these changes
Nov 2, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__cuda/barrier.h
Outdated
Show resolved
Hide resolved
libcudacxx/.upstream-tests/test/cuda/barrier/cp_async_bulk_tensor_4d.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__cuda/barrier.h
Outdated
Show resolved
Hide resolved
|
/backport |
1 similar comment
|
/backport |
|
Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits. |
|
/backport |
|
Successfully created backport PR for |
jrhemstad
removed
the
backport branch/2.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #650
cp_async_bulktests pre-c++14.memcpy_asyncwhenif constexpris not available.Checklist