Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom build backend to support build args #1692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions _custom_build/backend.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# Inspired by https://github.com/python-pillow/Pillow/pull/7171.

import sys

from setuptools.build_meta import * # noqa: F401, F403

backend_class = build_wheel.__self__.__class__


class _CustomBuildMetaBackend(backend_class):
def run_setup(self, setup_script="setup.py"):
if self.config_settings:

def config_has(value):
settings = self.config_settings.get("--build-option")
if settings:
if not isinstance(settings, list):
settings = [settings]
return value in settings

flags = []
for ext in (
"cpp_ext",
"cuda_ext",
"distributed_adam",
"distributed_lamb",
"permutation_search",
"bnp",
"xentropy",
"focal_loss",
"index_mul_2d",
"deprecated_fused_adam",
"deprecated_fused_lamb",
"fast_layer_norm",
"fmha",
"fast_multihead_attn",
"transducer",
"cudnn_gbn",
"peer_memory",
"nccl_p2p",
"fast_bottleneck",
"fused_conv_bias_relu",
):
ext = "--" + ext
if config_has(ext):
flags.append(ext)

if flags:
sys.argv = sys.argv[:1] + ["build_ext"] + flags + sys.argv[1:]
return super().run_setup(setup_script)

def build_wheel(
self, wheel_directory, config_settings=None, metadata_directory=None
):
self.config_settings = config_settings
return super().build_wheel(wheel_directory, config_settings, metadata_directory)


build_wheel = _CustomBuildMetaBackend().build_wheel
5 changes: 3 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[build-system]
requires = [
"setuptools",
"setuptools >= 40.8.0",
"wheel",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding packaging here or not?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left that to #1680 if that's fine.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense.

]
build-backend = "setuptools.build_meta"
build-backend = "backend" # custom setuptools.build_meta
backend-path = ["_custom_build"]