Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom build backend to support build args #1692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janEbert
Copy link

@janEbert janEbert commented Jul 6, 2023

This implements a custom build backend, inspired by the solution used by Pillow.

--build-options aren't actually passed to the build_wheel command for reasons unknown to me. So this patches setuptools.build_meta to take the flags manually.

The setuptools version requirement of 40.8.0 was also adopted from Pillow. It is the version that introduced the build_meta:__legacy__ backend.

This actually fixes what #1690 meant to do and seems fully backward-compatible.

This implements a custom build backend, inspired by [the solution used
by Pillow](python-pillow/Pillow#7171).

The setuptools version requirement of 40.8.0 was also adopted from
Pillow. It is the version that introduced the `build_meta:__legacy__`
backend.
@janEbert
Copy link
Author

janEbert commented Jul 6, 2023

Ref #1679.

@@ -1,6 +1,7 @@
[build-system]
requires = [
"setuptools",
"setuptools >= 40.8.0",
"wheel",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding packaging here or not?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left that to #1680 if that's fine.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense.

@crcrpar crcrpar self-requested a review July 18, 2023 06:47
@Quentin-Anthony
Copy link

I and others are still facing issues that this PR, coupled with #1680, would resolve. Is there anything I can do (testing, fix any remaining hangups, etc) to get this merged into upstream?

@loadams
Copy link

loadams commented Oct 30, 2023

@crcrpar - thoughts on merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants