Animate poly lights #137
Merged
Animate poly lights #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change in functionality, just to make the code more manageable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the color of poly lights with multiple frames. For #134
Previously, for materials consisting of multiple frames, only the emissive data from the first frame would be used to set up the poly light. (The mitigation was to not create poly lights from animated materials.)
Now, poly light colors are updated as well when the "world" is animated.
Some properties are different from frame to frame but can't change dynamically; they're dealt with as such:
is_lightproperty: As soon as a single frame has this property a poly light is created.Other properties (e.g.
emissive_factor) still apply per frame.