Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge r1.7.0 main #3773

Merged
merged 22 commits into from
Mar 1, 2022
Merged

Merge r1.7.0 main #3773

merged 22 commits into from
Mar 1, 2022

Conversation

ericharper
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

yzhang123 and others added 18 commits February 28, 2022 13:56
@yzhang123 @ericharper
Tn bug 1.7.0 (#3730)
565cf2b 
* fix es and fr bug

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add file

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
@Oktai15 @ericharper
[TTS] Fix bugs in E2E TTS, Mixer-TTS and FastPitch (#3740)
e24a309 
* fix bugs

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* fix bug in e2e tts and mixer tts

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>
@titu1994 @ericharper
Mirror AN4 data while servers are down (#3743)
348a963 
Signed-off-by: smajumdar <titu1994@gmail.com>
@ericharper
Bugfix for GPT eval (#3744)
024630d 
* use tokens_cut not tokens

Signed-off-by: ericharper <complex451@gmail.com>

* remove precision conversion and comment jit for bias gelu

Signed-off-by: ericharper <complex451@gmail.com>

* revert comment update mbs in config

Signed-off-by: ericharper <complex451@gmail.com>

* calculate micro_batch_size during complete and compute_logprobs

Signed-off-by: ericharper <complex451@gmail.com>
@sam1373 @ericharper
ASR SSL update (#3746)
fb9e03e 
* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>
@sam1373 @ericharper
Fix SSL configs for 1.7 (#3748)
6027135 
* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>
@ekmb @titu1994 @ericharper
punct process bug fix (#3747)
529f597 
Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
@VahidooX @titu1994 @ericharper
updated conformer models. (#3741)
37c3a32 
Signed-off-by: Vahid <vnoroozi@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
@yaoyu-33 @ericharper
Yuya/megatron t5 glue eval (#3751)
f35f8e1 
* Add megatron t5 glue eval-only script

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval default configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update config comments

Signed-off-by: Yu Yao <yuya@nvidia.com>

Co-authored-by: Yu Yao <yuya@nvidia.com>
@sam1373 @ericharper
Specify gpus in SSL notebook (#3753)
68a6d19 
* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>
@ekmb @ericharper
Duplex model inference fix, money encoder fix (#3754)
e065b98 
Signed-off-by: ekmb <ebakhturina@nvidia.com>
@titu1994 @ericharper
Update docs for RNNT and overriding fused batch size (#3755)
5794afd 
Signed-off-by: smajumdar <titu1994@gmail.com>
@yidong72 @michalivne @ericharper
fix consumed samples calculation + PTune Model bugs (#3738)
6646c3b 
* fix the way computing consumed samples

Signed-off-by: Yi Dong <yidong@nvidia.com>

* fixed ptune model

Signed-off-by: Yi Dong <yidong@nvidia.com>

* make sure notebook is working

Signed-off-by: Yi Dong <yidong@nvidia.com>

* added try-catch

Signed-off-by: Yi Dong <yidong@nvidia.com>

Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
@sam1373 @ericharper
fix directories in ssl notebook (#3758)
cd91bb7 
* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* update dirs

Signed-off-by: sam1373 <samuelkriman@gmail.com>
@ekmb @yzhang123 @ericharper
TN docs update (#3735)
e8616df 
* TN docs update: audio based docs added, quick start, ref fixed, etc

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add deployment script dir and Sp TN

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
@blisc @ericharper
Update Tacotron2_Training.ipynb (#3769)
e5847b9 
Signed-off-by: Jason <jasoli@nvidia.com>
@ericharper
update branch
5dd77e2 
Signed-off-by: ericharper <complex451@gmail.com>
@ericharper
update requirements and package info
a2bbf15 
Signed-off-by: ericharper <complex451@gmail.com>
@ericharper ericharper requested a review from titu1994 February 28, 2022 20:59
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 2 alerts when merging a2bbf15 into 222b513 - view on LGTM.com

new alerts:

  • 2 for Unused import

@ericharper
revert
2afe93a 
Signed-off-by: ericharper <complex451@gmail.com>
@ericharper
revert
d0837fc 
Signed-off-by: ericharper <complex451@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 2 alerts when merging d0837fc into 222b513 - view on LGTM.com

new alerts:

  • 2 for Unused import

@ericharper
update branch
3c705e6 
Signed-off-by: ericharper <complex451@gmail.com>
@ericharper
remove unused import
ff0d3e5 
Signed-off-by: ericharper <complex451@gmail.com>
titu1994
titu1994 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems I made a mistake in one of the docs, I'll fix it when I'm back next week cl

@titu1994 titu1994 merged commit 063d349 into main Mar 1, 2022
@titu1994 titu1994 deleted the merge_r1.7.0_main branch March 1, 2022 00:44
fayejf pushed a commit that referenced this pull request Mar 2, 2022
@ericharper @yzhang123
@Oktai15 @titu1994 @sam1373 @ekmb @VahidooX @yaoyu-33 @yidong72 @michalivne @blisc @fayejf
Merge r1.7.0 main (#3773)
0fcd281 
* Tn bug 1.7.0 (#3730)

* fix es and fr bug

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add file

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* [TTS] Fix bugs in E2E TTS, Mixer-TTS and FastPitch (#3740)

* fix bugs

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* fix bug in e2e tts and mixer tts

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* Mirror AN4 data while servers are down (#3743)

Signed-off-by: smajumdar <titu1994@gmail.com>

* Bugfix for GPT eval  (#3744)

* use tokens_cut not tokens

Signed-off-by: ericharper <complex451@gmail.com>

* remove precision conversion and comment jit for bias gelu

Signed-off-by: ericharper <complex451@gmail.com>

* revert comment update mbs in config

Signed-off-by: ericharper <complex451@gmail.com>

* calculate micro_batch_size during complete and compute_logprobs

Signed-off-by: ericharper <complex451@gmail.com>

* ASR SSL update (#3746)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Fix SSL configs for 1.7 (#3748)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* punct process bug fix (#3747)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* updated conformer models. (#3741)

Signed-off-by: Vahid <vnoroozi@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* Yuya/megatron t5 glue eval (#3751)

* Add megatron t5 glue eval-only script

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval default configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update config comments

Signed-off-by: Yu Yao <yuya@nvidia.com>

Co-authored-by: Yu Yao <yuya@nvidia.com>

* Specify gpus in SSL notebook (#3753)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Duplex model inference fix, money encoder fix (#3754)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* Update docs for RNNT and overriding fused batch size (#3755)

Signed-off-by: smajumdar <titu1994@gmail.com>

* fix consumed samples calculation + PTune Model bugs (#3738)

* fix the way computing consumed samples

Signed-off-by: Yi Dong <yidong@nvidia.com>

* fixed ptune model

Signed-off-by: Yi Dong <yidong@nvidia.com>

* make sure notebook is working

Signed-off-by: Yi Dong <yidong@nvidia.com>

* added try-catch

Signed-off-by: Yi Dong <yidong@nvidia.com>

Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>

* fix directories in ssl notebook (#3758)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* update dirs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* TN docs update (#3735)

* TN docs update: audio based docs added, quick start, ref fixed, etc

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add deployment script dir and Sp TN

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>

* Update Tacotron2_Training.ipynb (#3769)

Signed-off-by: Jason <jasoli@nvidia.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* update requirements and package info

Signed-off-by: ericharper <complex451@gmail.com>

* revert

Signed-off-by: ericharper <complex451@gmail.com>

* revert

Signed-off-by: ericharper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* remove unused import

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Co-authored-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Samuel Kriman <samuelkriman@gmail.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Vahid Noroozi <VahidooX@users.noreply.github.com>
Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <yuya@nvidia.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Jason <jasoli@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titu1994 titu1994 titu1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ericharper @titu1994 @yzhang123 @Oktai15 @sam1373 @ekmb @VahidooX @yaoyu-33 @yidong72 @blisc